Merge pull request #119 from FormidableLabs/feature/support-no-scopes

Feature/support no scopes

Author: kadikraman

README.md

@@ -84,7 +84,7 @@ with optional overrides.
 * **clientId** - (`string`) _REQUIRED_ your client id on the auth server
 * **clientSecret** - (`string`) client secret to pass to token exchange requests. :warning: Read more about [client secrets](#note-about-client-secrets)
 * **redirectUrl** - (`string`) _REQUIRED_ the url that links back to your app with the auth code
-* **scopes** - (`array<string>`) _REQUIRED_ the scopes for your token, e.g. `['email', 'offline_access']`
+* **scopes** - (`array<string>`) the scopes for your token, e.g. `['email', 'offline_access']`.
 * **additionalParameters** - (`object`) additional parameters that will be passed in the authorization request.
   Must be string values! E.g. setting `additionalParameters: { hello: 'world', foo: 'bar' }` would add
   `hello=world&foo=bar` to the authorization request.

index.js

@@ -3,8 +3,6 @@ import { NativeModules, Platform } from 'react-native';
 
 const { RNAppAuth } = NativeModules;
 
-const validateScopes = scopes =>
-  invariant(scopes && scopes.length, 'Scope error: please add at least one scope');
 const validateIssuerOrServiceConfigurationEndpoints = (issuer, serviceConfiguration) =>
   invariant(
     typeof issuer === 'string' ||
@@ -34,7 +32,6 @@ export const authorize = ({
   serviceConfiguration,
   dangerouslyAllowInsecureHttpRequests = false,
 }) => {
-  validateScopes(scopes);
   validateIssuerOrServiceConfigurationEndpoints(issuer, serviceConfiguration);
   validateClientId(clientId);
   validateRedirectUrl(redirectUrl);
@@ -69,7 +66,6 @@ export const refresh = (
   },
   { refreshToken }
 ) => {
-  validateScopes(scopes);
   validateIssuerOrServiceConfigurationEndpoints(issuer, serviceConfiguration);
   validateClientId(clientId);
   validateRedirectUrl(redirectUrl);

index.spec.js

@@ -78,18 +78,6 @@ describe('AppAuth', () => {
       }).toThrow('Config error: clientId must be a string');
     });
 
-    it('throws an error when no scopes are passed in', () => {
-      expect(() => {
-        authorize({ ...config, scopes: undefined });
-      }).toThrow('Scope error: please add at least one scope');
-    });
-
-    it('throws an error when an empty scope array is passed in', () => {
-      expect(() => {
-        authorize({ ...config, scopes: [] });
-      }).toThrow('Scope error: please add at least one scope');
-    });
-
     it('calls the native wrapper with the correct args on iOS', () => {
       authorize(config);
       expect(mockAuthorize).toHaveBeenCalledWith(
@@ -206,18 +194,6 @@ describe('AppAuth', () => {
       }).toThrow('Please pass in a refresh token');
     });
 
-    it('throws an error when no scopes are passed in', () => {
-      expect(() => {
-        refresh({ ...config, scopes: undefined }, { refreshToken: 'such-token' });
-      }).toThrow('Scope error: please add at least one scope');
-    });
-
-    it('throws an error when an empty scope array is passed in', () => {
-      expect(() => {
-        refresh({ ...config, scopes: [] }, { refreshToken: 'such-token' });
-      }).toThrow('Scope error: please add at least one scope');
-    });
-
     it('calls the native wrapper with the correct args on iOS', () => {
       refresh({ ...config }, { refreshToken: 'such-token' });
       expect(mockRefresh).toHaveBeenCalledWith(