You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+49-6Lines changed: 49 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -42,8 +42,8 @@ If you don't feel comfortable making changes to both, feel free to contribute
42
42
## How do I contribute code?
43
43
44
44
1. Search for something you'd like to change. This can be an open issue, or just a feature
45
-
you'd like to implement. Make sure that no one else is already on it, so that you're not
46
-
duplicating someone else's effort.
45
+
you'd like to implement. Make sure that no one else is already on it, so that you're not
46
+
duplicating someone else's effort.
47
47
48
48
2. Fork the repository and then clone it, i.e. `git clone https://github.com/YOUR_NAME/react-native-app-auth.git`
49
49
@@ -57,11 +57,54 @@ If you don't feel comfortable making changes to both, feel free to contribute
57
57
58
58
7. Commit your changes with a short description, `git add -A && git commit -m 'Your meaningful and descriptive message'`
59
59
60
-
6. Push your new branch, `git push -u origin fix/issue-123`
60
+
8. Push your new branch, `git push -u origin fix/issue-123`
61
61
62
-
7. Finally, open a pull request with a title and a short summary of what has been changed and why.
62
+
9. Finally, open a pull request with a title and a short summary of what has been changed and why.
63
63
64
-
8. Wait for a maintainer to review it and make some changes as they're being recommended and as you see fit.
64
+
10. Wait for a maintainer to review it and make some changes as they're being recommended and as you see fit.
65
65
66
-
9. Get it merged and make cool a celebratory pose! :dancer:
66
+
11. Get it merged and make cool a celebratory pose! :dancer:
67
67
68
+
### Using changesets
69
+
70
+
Our official release path is to use automation to perform the actual publishing of our packages. The steps are to:
71
+
72
+
1. A human developer adds a changeset. Ideally this is as a part of a PR that will have a version impact on a package.
73
+
2. On merge of a PR our automation system opens a "Version Packages" PR.
74
+
3. On merging the "Version Packages" PR, the automation system publishes the packages.
75
+
76
+
Here are more details:
77
+
78
+
### Add a changeset
79
+
80
+
When you would like to add a changeset (which creates a file indicating the type of change), in your branch/PR issue this command:
81
+
82
+
```sh
83
+
$ yarn changeset
84
+
```
85
+
86
+
to produce an interactive menu. Navigate the packages with arrow keys and hit `<space>` to select 1+ packages. Hit `<return>` when done. Select semver versions for packages and add appropriate messages. From there, you'll be prompted to enter a summary of the change. Some tips for this summary:
87
+
88
+
1. Aim for a single line, 1+ sentences as appropriate.
89
+
2. Include issue links in GH format (e.g. `#123`).
90
+
3. You don't need to reference the current pull request or whatnot, as that will be added later automatically.
91
+
92
+
After this, you'll see a new uncommitted file in `.changesets` like:
93
+
94
+
```sh
95
+
$ git status
96
+
# ....
97
+
Untracked files:
98
+
(use "git add <file>..." to include in what will be committed)
99
+
.changeset/flimsy-pandas-marry.md
100
+
```
101
+
102
+
Review the file, make any necessary adjustments, and commit it to source. When we eventually do a package release, the changeset notes and version will be incorporated!
103
+
104
+
### Creating versions
105
+
106
+
On a merge of a feature PR, the changesets GitHub action will open a new PR titled `"Version Packages"`. This PR is automatically kept up to date with additional PRs with changesets. So, if you're not ready to publish yet, just keep merging feature PRs and then merge the version packages PR later.
107
+
108
+
### Publishing packages
109
+
110
+
On the merge of a version packages PR, the changesets GitHub action will publish the packages to npm.
0 commit comments