Skip to content

Commit 258cb6d

Browse files
authored
Custom Nonce passing as an additional parameter is not properly configured (#736)
* Setup nonce configuration correctly * Downgrade appauth to 0.9.1 to avoid conflictions * Change nonce configuration * Keep the android's appauth version in 1.11.0 * Remove the nonce once used Remove the nonce from the additional parameters once it's added to the authRequestBuilder
1 parent 5c74547 commit 258cb6d

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

android/src/main/java/com/rnappauth/RNAppAuthModule.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,9 +674,16 @@ private void authorizeWithConfiguration(
674674
authRequestBuilder.setState(additionalParametersMap.get("state"));
675675
additionalParametersMap.remove("state");
676676
}
677+
678+
if (additionalParametersMap.containsKey("nonce")) {
679+
authRequestBuilder.setNonce(additionalParametersMap.get("nonce"));
680+
additionalParametersMap.remove("nonce");
681+
682+
}
677683
if (additionalParametersMap.containsKey("ui_locales")) {
678684
authRequestBuilder.setUiLocales(additionalParametersMap.get("ui_locales"));
679685
additionalParametersMap.remove("ui_locales");
686+
680687
}
681688

682689
authRequestBuilder.setAdditionalParameters(additionalParametersMap);

ios/RNAppAuth.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ - (void)authorizeWithConfiguration: (OIDServiceConfiguration *) configuration
319319

320320
NSString *codeVerifier = usePKCE ? [[self class] generateCodeVerifier] : nil;
321321
NSString *codeChallenge = usePKCE ? [[self class] codeChallengeS256ForVerifier:codeVerifier] : nil;
322-
NSString *nonce = useNonce ? [[self class] generateState] : nil;
322+
NSString *nonce = useNonce ? additionalParameters[@"nonce"]? additionalParameters[@"nonce"]: [[self class] generateState] : nil ;
323323

324324
// builds authentication request
325325
OIDAuthorizationRequest *request =

0 commit comments

Comments
 (0)