Skip to content

Commit 1fd30d1

Browse files
authored
Revert replaceing 'compile' with 'implementation' in android/build.gradle (#249)
* Revert "Replace 'compile' with 'implementation' (#242)" This reverts commit 727945d. * Add readme comment on patch package
1 parent 96ddd4c commit 1fd30d1

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,8 @@ class AppDelegate: UIApplicationDelegate, RNAppAuthAuthorizationFlowManager {
314314

315315
### Android Setup
316316

317+
**Note:** for RN >= 0.57, you will get a warning about compile being obsolete. To get rid of this warning, use [patch-package](https://github.com/ds300/patch-package) to replace compile with implementation [as in this PR](https://github.com/FormidableLabs/react-native-app-auth/pull/242) - we're not deploying this right now, because it would break the build for RN < 57.
318+
317319
To setup the Android project, you need to perform two steps:
318320

319321
1. [Install Android support libraries](#install-android-support-libraries)

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ repositories {
3434
}
3535

3636
dependencies {
37-
implementation 'com.facebook.react:react-native:+'
38-
implementation "net.openid:appauth:0.7.1"
37+
compile 'com.facebook.react:react-native:+'
38+
compile "net.openid:appauth:0.7.1"
3939
}

0 commit comments

Comments
 (0)