fix(charts): remove any sort on chart and remove default join behaviour on line chart (#588)

Author: matthv

app/services/forest_liana/line_stat_getter.rb

@@ -23,7 +23,7 @@ def get_format
     end
 
     def perform
-      value = get_resource().joins(@includes)
+      value = get_resource()
 
       filters = ForestLiana::ScopeManager.append_scope_for_user(@params[:filters], @user, @resource.name)
 

app/services/forest_liana/stat_getter.rb

@@ -8,5 +8,11 @@ def initialize(resource, params, forest_user)
       @user = forest_user
       compute_includes()
     end
+
+    def get_resource
+      super
+      @resource.reorder('')
+    end
+
   end
 end

spec/dummy/app/models/owner.rb

@@ -1,3 +1,5 @@
 class Owner < ActiveRecord::Base
   has_many :trees
+
+  default_scope { order('hired_at ASC') }
 end

spec/services/forest_liana/line_stat_getter_spec.rb

@@ -7,6 +7,7 @@ module ForestLiana
     before(:each) do
       ForestLiana::ScopeManager.invalidate_scope_cache(rendering_id)
       allow(ForestLiana::ScopeManager).to receive(:fetch_scopes).and_return(scopes)
+      Owner.delete_all
     end
 
     describe 'Check client_timezone function' do
@@ -54,5 +55,21 @@ module ForestLiana
         end
       end
     end
+
+    describe 'Check new instance function' do
+      describe 'Using a Count aggregation' do
+        it 'should remove any order to the resource' do
+          Owner.create(name: 'Shuri', hired_at: Date.parse('09-11-2022'));
+          stat = LineStatGetter.new(Owner, {
+            timezone: "Europe/Paris",
+            aggregate: "Count",
+            time_range: "Day",
+            group_by_date_field: "hired_at",
+          }, user)
+
+          expect(stat.get_resource.where(name: "Shuri").to_sql.downcase.exclude? "order by").to be true
+        end
+      end
+    end
   end
 end