Skip to content

Commit fa1a56e

Browse files
realSpokNicolas Moreau
and
Nicolas Moreau
authored
fix: prevent unauthorized live queries (#1291)
Co-authored-by: Nicolas Moreau <nicolas.moreau76@gmail.com>
1 parent a36ba3b commit fa1a56e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/agent/src/services/authorization/authorization.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ export default class AuthorizationService {
5252
});
5353

5454
if (
55-
context.request?.body &&
55+
context.request?.query &&
5656
CollectionActionEvent.Browse === event &&
57-
(context.request.body as { segmentQuery?: string }).segmentQuery
57+
(context.request.query as { segmentQuery?: string }).segmentQuery
5858
) {
59-
const { segmentQuery, connectionName } = context.request.body as {
59+
const { segmentQuery, connectionName } = context.request.query as {
6060
segmentQuery?: string;
6161
connectionName?: string;
6262
};

packages/agent/test/services/authorization/authorization.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ describe('AuthorizationService', () => {
8989

9090
const context = {
9191
request: {
92-
body: {
92+
query: {
9393
segmentQuery: `SELECT id FROM books where type = 'comics'`,
9494
connectionName: 'library',
9595
},
@@ -134,7 +134,7 @@ describe('AuthorizationService', () => {
134134

135135
const context = {
136136
request: {
137-
body: {
137+
query: {
138138
segmentQuery: `DROP TABLE books;`,
139139
connectionName: 'library',
140140
},

0 commit comments

Comments
 (0)