feat: reactant support #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Mar 13, 2025
src/interface.jl
Outdated
Comment on lines
297
to
300
| _assert_positive_eta(eta) = _assert_positive_eta(eta, eta < 0) | ||
| function _assert_positive_eta(eta, cond::Bool) | ||
| cond && throw(DomainError(eta, "the learning rate cannot be negative")) | ||
| end |
There was a problem hiding this comment.
If this function is being overloaded anyways, could the eta < 0 check not be moved inside _assert_positive_eta?
|
While I don't have any objections to this in principle, there are a couple of things to consider:
|
|
Added tests for the optimisers. We just need the assert check as a temporary means till we support throwing errors from inside MLIR |
avik-pal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactantdoesn't allow tracing conditionals directly right now. Add a hook rn to prevent reactant tracing.