Skip to content

Commit cb042c1

Browse files
committed
Incorporate review feedback
1 parent 0d2b842 commit cb042c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/dev-guide/contributing.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ To fix a bug in Metalhead.jl, you can [open a PR](https://github.com/FluxML/Meta
1515
To add a new model architecture to Metalhead.jl, you can [open a PR](https://github.com/FluxML/Metalhead.jl/pulls). Keep in mind a few guiding principles for how this package is designed:
1616

1717
- reuse layers from Flux as much as possible (e.g. use `Parallel` before defining a `Bottleneck` struct)
18-
- adhere as closely as possible to a reference such as a published paper (i.e. the structure of your model should be intuitive based on the paper)
19-
- use generic functional builders (e.g. [`resnet`](#) is the core function that build "ResNet-like" models based on the principles in the paper)
18+
- adhere as closely as possible to a reference such as a published paper (i.e. the structure of your model should follow intuitively from the paper)
19+
- use generic functional builders (e.g. [`resnet`](#) is the core function that builds "ResNet-like" models)
2020
- use multiple dispatch to add convenience constructors that wrap your functional builder
2121

2222
When in doubt, just open a PR! We are more than happy to help review your code to help it align with the rest of the library. After adding a model, you might consider adding some pre-trained weights (see below).

0 commit comments

Comments
 (0)