Skip to content

Commit f49ec34

Browse files
committed
Revert tversky_loss changes
1 parent a67400f commit f49ec34

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

src/losses/functions.jl

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -516,26 +516,12 @@ Calculated as:
516516
517517
1 - sum(|y .* ŷ| + 1) / (sum(y .* ŷ + (1 - β)*(1 .- y) .* ŷ + β*y .* (1 .- ŷ)) + 1)
518518
519-
# Example
520-
```jldoctest
521-
julia> y = [0, 1, 0, 1, 1, 1];
522-
523-
julia> ŷ_fp = [1, 1, 1, 1, 1, 1]; # 2 false positive -> 2 wrong predictions
524-
525-
julia> ŷ_fnp = [1, 1, 0, 1, 1, 0]; # 1 false negative, 1 false positive -> 2 wrong predictions
526-
527-
julia> Flux.tversky_loss(ŷ_fnp, y)
528-
0.19999999999999996
529-
530-
julia> Flux.tversky_loss(ŷ_fp, y) < Flux.tversky_loss(ŷ_fnp, y) # FN is given more weight
531-
true
532-
```
533519
"""
534520
function tversky_loss(ŷ, y; β = ofeltype(ŷ, 0.7))
535521
_check_sizes(ŷ, y)
536522
#TODO add agg
537523
num = sum(y .* ŷ) + 1
538-
den = sum(y .*+ (1 - β) * (1 .- y) .*+ β * y .* (1 .- ŷ)) + 1
524+
den = sum(y .*+ β * (1 .- y) .*+ (1 - β) * y .* (1 .- ŷ)) + 1
539525
1 - num / den
540526
end
541527

test/losses.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ y = [1.0 0.5 0.3 2.4]
163163
end
164164

165165
@testset "tversky_loss" begin
166-
@test Flux.tversky_loss(ŷ, y) 0.028747433264887046
167-
@test Flux.tversky_loss(ŷ, y, β=0.8) 0.050200803212851364
166+
@test Flux.tversky_loss(ŷ, y) -0.06772009029345383
167+
@test Flux.tversky_loss(ŷ, y, β=0.8) -0.09490740740740744
168168
@test Flux.tversky_loss(y, y) -0.5576923076923075
169169
end
170170

0 commit comments

Comments
 (0)