-
Notifications
You must be signed in to change notification settings - Fork 42
getFlags
removes identity identifier in evaluation context
#262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @jhoermann, thanks for raising this. I think I understand the issue that you're describing, but it would be very helpful for us if you are able to share a minimal example to reproduce it? |
Yes here: https://stackblitz.com/edit/flagsmith-bug-setcontext?file=main.js. As you can see the identifier is being stripped from the context @matthewelwell. |
Great, thanks for sharing that @jhoermann - we'll take a look into this and get it fixed up. Alternatively, if you want to submit a PR, we'd gladly accept it. |
I opened up a PR - have a look @matthewelwell: #263. Still need to verify that this solves the issue and need to add a test for it though. |
Hello @jhoermann — we have identified an error in the backend that caused this issue and deployed the fix. We've observed correct behaviour in the reproduction StackBlitz you've provided. Please confirm whether the fix is working for you. |
Yes that resolves the issue as the identifier now gets returned by the backend endpoint @khvn26 @matthewelwell. |
Hello, I have same problem, but in my company we use self-hosted flagsmith, and we can't just update to the newest version, so can we reopen PR of @jhoermann to fix this problem on the client side |
This is now released under version 8.0.1 🚀 |
In the current flagsmith version 7.0.1 the identity identifier gets reset within the
getFlags
backend call:getFlags
/ init backend call -> identifier is lost in evaluation contextThis results in
setContext
to fail because the identifier is missing:The text was updated successfully, but these errors were encountered: