Fix -Wparentheses warning in gpre/pat

mrotteveel · mrotteveel · commit b28760c90359 · 2025-07-15T12:44:40.000+02:00
+ constexpr
diff --git a/src/gpre/pat.cpp b/src/gpre/pat.cpp
@@ -57,7 +57,7 @@ enum pat_t {
 	FR							// Field reference
 };
 
-static const struct ops
+static constexpr struct ops
 {
 	pat_t ops_type;
 	TEXT ops_string[3];
@@ -183,7 +183,7 @@ void PATTERN_expand( USHORT column, const TEXT* pattern, PAT* args)
 								// values printed out are signed.
 	SLONG long_value;
 	TEXT c;
-	while (c = *pattern++)
+	while ((c = *pattern++))
 	{
 		if (c != '%')
 		{

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ enum pat_t {`
`57`	`57`	`FR // Field reference`
`58`	`58`	`};`
`59`	`59`
`60`		`-static const struct ops`
	`60`	`+static constexpr struct ops`
`61`	`61`	`{`
`62`	`62`	`pat_t ops_type;`
`63`	`63`	`TEXT ops_string[3];`
`@@ -183,7 +183,7 @@ void PATTERN_expand( USHORT column, const TEXT* pattern, PAT* args)`
`183`	`183`	`// values printed out are signed.`
`184`	`184`	`SLONG long_value;`
`185`	`185`	`TEXT c;`
`186`		`- while (c = *pattern++)`
	`186`	`+ while ((c = *pattern++))`
`187`	`187`	`{`
`188`	`188`	`if (c != '%')`
`189`	`189`	`{`