Fixed topic node updates being handled as unrecognised chat nodes and being added to chat history.

Added method for deleting chat posts from a story
Added getter for a node's user id

Author: Fiddlekins

js/Akun.js

@@ -193,16 +193,16 @@ class Akun {
 		return this._closeNode(readerPostNodeId);
 	}
 
-	ban(storyId, postId) {
+	ban(storyId, chatNodeId) {
 		return this.core.post(`/api/anonkun/ban`, {
-			blockFor: postId,
+			blockFor: chatNodeId,
 			blockFrom: storyId
 		}, false);
 	}
 
-	unban(storyId, postId) {
+	unban(storyId, chatNodeId) {
 		return this.core.delete(`/api/anonkun/ban`, {
-			blockFor: postId,
+			blockFor: chatNodeId,
 			blockFrom: storyId
 		}, false);
 	}
@@ -211,6 +211,14 @@ class Akun {
 		return this.core.get(`/api/anonkun/story/bans/${storyId}`);
 	}
 
+	deleteChatNodeFromStory(storyId, chatNodeId) {
+		// Specific method name because deleting chapters and topic posts behave differently
+		return this.core.delete(`/api/anonkun/node`, {
+			deleteFrom: storyId,
+			nid: chatNodeId
+		}, false);
+	}
+
 	_openNode(nodeId) {
 		return this.core.post(`/api/anonkun/editChapter`, {
 			'_id': nodeId,

js/nodes/Node.js

@@ -92,6 +92,16 @@ class Node {
 		return this._userName;
 	}
 
+	/**
+	 * The userId of the node creator
+	 *
+	 * @member {?string}
+	 * @readonly
+	 */
+	get userId(){
+		return this._userId;
+	}
+
 	/**
 	 * The avatar of the node creator
 	 *

js/threads/BaseThread.js

@@ -96,6 +96,9 @@ class BaseThread extends events.EventEmitter {
 	}
 
 	async _newMessage(data, notify = true) {
+		if (!this._checkBelongsInHistory(data)) {
+			return;
+		}
 		let nodeData = data;
 		const nodeId = nodeData['_id'];
 		const isUpdate = this._isNodeUpdate(nodeData);
@@ -118,13 +121,21 @@ class BaseThread extends events.EventEmitter {
 		}
 	}
 
-	_makeNode(nodeData) {
+	_checkBelongsInHistory(nodeData) {
 		switch (true) {
 			// Extend with type handlers
 			default:
 				if (!this._akun.silent) {
 					console.warn(new Error(`BaseThread received unrecognised nodeType '${nodeData['nt']}':\n${JSON.stringify(nodeData, null, '\t')}`));
 				}
+				return true;
+		}
+	}
+
+	_makeNode(nodeData) {
+		switch (true) {
+			// Extend with type handlers
+			default:
 				return new Node(nodeData);
 		}
 	}

js/threads/ChatThread.js

@@ -9,6 +9,10 @@ function isChoice(nodeData) {
 	return nodeData['nt'] === 'choice';
 }
 
+function isTopic(nodeData) {
+	return nodeData['nt'] === 'post';
+}
+
 class ChatThread extends BaseThread {
 	constructor(akun, nodeData) {
 		super(akun, nodeData);
@@ -33,16 +37,30 @@ class ChatThread extends BaseThread {
 		super._disconnect();
 	}
 
-	_makeNode(nodeData) {
+	_checkBelongsInHistory(nodeData) {
 		switch (true) {
 			case isChat(nodeData):
-				return new ChatNode(nodeData);
+				return true;
 			case isChoice(nodeData):
-				return new ChoiceNode(nodeData);
+				return true;
+			case isTopic(nodeData):
+				// TODO handle topic node updates
+				return false;
 			default:
 				if (!this._akun.silent) {
 					console.warn(new Error(`ChatThread received unrecognised nodeType '${nodeData['nt']}':\n${JSON.stringify(nodeData, null, '\t')}`));
 				}
+				return true;
+		}
+	}
+
+	_makeNode(nodeData) {
+		switch (true) {
+			case isChat(nodeData):
+				return new ChatNode(nodeData);
+			case isChoice(nodeData):
+				return new ChoiceNode(nodeData);
+			default:
 				return new Node(nodeData);
 		}
 	}

js/threads/StoryThread.js

@@ -80,6 +80,22 @@ class StoryThread extends BaseThread {
 		super._disconnect();
 	}
 
+	_checkBelongsInHistory(nodeData) {
+		switch (true) {
+			case isChapter(nodeData):
+				return true;
+			case isChoice(nodeData):
+				return true;
+			case isReaderPost(nodeData):
+				return true;
+			default:
+				if (!this._akun.silent) {
+					console.warn(new Error(`StoryThread received unrecognised nodeType '${nodeData['nt']}':\n${JSON.stringify(nodeData, null, '\t')}`));
+				}
+				return true;
+		}
+	}
+
 	_makeNode(nodeData) {
 		switch (true) {
 			case isChapter(nodeData):
@@ -89,9 +105,6 @@ class StoryThread extends BaseThread {
 			case isReaderPost(nodeData):
 				return new ReaderPostNode(nodeData);
 			default:
-				if (!this._akun.silent) {
-					console.warn(new Error(`StoryThread received unrecognised nodeType '${nodeData['nt']}':\n${JSON.stringify(nodeData, null, '\t')}`));
-				}
 				return new Node(nodeData);
 		}
 	}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "akun-api",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "A module intended to enable easy interactions with Anonkun",
   "main": "index.js",
   "type": "module",