Skip to content

Commit f199153

Browse files
committed
Credit wrongwrong for 451 test
1 parent 3a29578 commit f199153

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

release-notes/CREDITS-2.x

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ wrongwrong (k163377@github)
1717
* #468: Improved support for value classes
1818
(2.13)
1919

20+
wrongwrong (k163377@github)
21+
* #460: Test for GitHub #451 (`-` in property name handling)
22+
(2.13)
23+
2024
Christopher Mason (masoncj@github)
2125
* #194: Contributed test case for @JsonIdentityInfo usage
2226
(2.12.NEXT)

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/GitHub451.kt renamed to src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/GitHub451.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package com.fasterxml.jackson.module.kotlin.test.github
1+
package com.fasterxml.jackson.module.kotlin.test.github.failing
22

33
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
4-
import com.fasterxml.jackson.module.kotlin.readValue
5-
import org.junit.Ignore
4+
import com.fasterxml.jackson.module.kotlin.test.expectFailure
5+
import org.junit.ComparisonFailure
66
import org.junit.Test
77
import kotlin.test.assertEquals
88

@@ -20,12 +20,13 @@ class GitHub451 {
2020
val mapper = jacksonObjectMapper()
2121

2222
@Test
23-
@Ignore
2423
fun serializeTest() {
2524
val expected = """{"foo-bar":"a","baz-qux":"b","quux-corge":"a","grault-graply":"b"}"""
2625

2726
val src = Target("a", "b")
2827
val json = mapper.writeValueAsString(src)
29-
assertEquals(expected, json)
28+
expectFailure<ComparisonFailure>("GitHub #451 has been fixed!") {
29+
assertEquals(expected, json)
30+
}
3031
}
3132
}

0 commit comments

Comments
 (0)