-
-
Notifications
You must be signed in to change notification settings - Fork 142
logback-test.xml
in the Main Avro resources folder can cause runtime issues for applications
#379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds like a flaw, unintended so PR (against 2.14 branch so I can merge forward) would be most welcome. |
Absolutely. One question, though—since that file doesn't exist on the 2.14 branch, will this need a separate commit on the 2.15 branch to remove it once the test file is added? |
Oh ok then just do that for 2.15 branch. I haven't had a chance to check (traveling this week). |
Hope you don't mind me raising this PR with reaching out first. Just trying to help out, as we're also experiencing our apps failing on start up. |
logback-test.xml
in the Main Avro Resources Folder Can Cause Runtime Issues for Applicationslogback-test.xml
in the Main Avro resources folder can cause runtime issues for applications
@techabstraction Not all, thanks for PR! I wish I had remembered to wait for this before 2.15.1 release, but it'll be in 2.15.2. |
Thanks @cowtowncoder . Any idea when we can expect
|
@techabstraction Normally it'd take a while between patches, but "fortunately" there are multiple jar/build issues that are problematic with 2.15.1; as well as one Record-related bug for which I personally need a new version :) Which is to say I'll probably try to get 2.15.2 released within a week or so. |
Hi @cowtowncoder . Just checking in, any update on when |
This week, today or tomorrow I hope. EDIT: was released on 2023-05-30. |
Hi, |
Thank you for verifying @SuvaAndiBill -- too bad this file was included but good things work again. |
Because this test logback file (located here) is in the
main
directory, it gets packaged and deployed as part of the release artifact. I have some apps running with Spring Boot 2.7.x and Logback and have observed that this test configuration file is getting picked up by Logback and causing the app to fail on startup due to a (perceived) misconfiguration. I believe this can be remediated by movinglogback-test.xml
to theavro/test/resources
directory.I am happy to open a pull request with this change myself but wanted to file an issue first and hear feedback from the maintainers. I am a huge fan of the work you do on this library
The text was updated successfully, but these errors were encountered: