Simplify code by using Double.isFinite() added in JDK 8 (#414)

Author: cowtowncoder

avro/src/main/java/com/fasterxml/jackson/dataformat/avro/deser/AvroParserImpl.java

@@ -161,13 +161,10 @@ public final void skipValue() throws IOException {
     public final boolean isNaN() {
         if (_currToken == JsonToken.VALUE_NUMBER_FLOAT) {
             if ((_numTypesValid & NR_DOUBLE) != 0) {
-                // 10-Mar-2017, tatu: Alas, `Double.isFinite(d)` only added in JDK 8
-                double d = _numberDouble;
-                return Double.isNaN(d) || Double.isInfinite(d);
+                return !Double.isFinite(_numberDouble);
             }
             if ((_numTypesValid & NR_FLOAT) != 0) {
-                float f = _numberFloat;
-                return Float.isNaN(f) || Float.isInfinite(f);
+                return !Float.isFinite(_numberFloat);
             }
         }
         return false;

cbor/src/main/java/com/fasterxml/jackson/dataformat/cbor/CBORParser.java

@@ -1868,13 +1868,10 @@ private final byte[] _getBinaryFromString(Base64Variant variant) throws IOExcept
     public boolean isNaN() {
         if (_currToken == JsonToken.VALUE_NUMBER_FLOAT) {
             if ((_numTypesValid & NR_DOUBLE) != 0) {
-                // 10-Mar-2017, tatu: Alas, `Double.isFinite(d)` only added in JDK 8
-                double d = _numberDouble;
-                return Double.isNaN(d) || Double.isInfinite(d);
+                return !Double.isFinite(_numberDouble);
             }
             if ((_numTypesValid & NR_FLOAT) != 0) {
-                float f = _numberFloat;
-                return Float.isNaN(f) || Float.isInfinite(f);
+                return !Float.isFinite(_numberFloat);
             }
         }
         return false;

protobuf/src/main/java/com/fasterxml/jackson/dataformat/protobuf/ProtobufParser.java

@@ -1495,13 +1495,10 @@ public int readBinaryValue(Base64Variant b64variant, OutputStream out) throws IO
     public boolean isNaN() {
         if (_currToken == JsonToken.VALUE_NUMBER_FLOAT) {
             if ((_numTypesValid & NR_DOUBLE) != 0) {
-                // 10-Mar-2017, tatu: Alas, `Double.isFinite(d)` only added in JDK 8
-                double d = _numberDouble;
-                return Double.isNaN(d) || Double.isInfinite(d);
+                return !Double.isFinite(_numberDouble);
             }
             if ((_numTypesValid & NR_FLOAT) != 0) {
-                float f = _numberFloat;
-                return Float.isNaN(f) || Float.isInfinite(f);
+                return !Float.isFinite(_numberFloat);
             }
         }
         return false;

smile/src/main/java/com/fasterxml/jackson/dataformat/smile/SmileParserBase.java

@@ -428,14 +428,11 @@ public final boolean isNaN() throws IOException {
             if (_numTypesValid == NR_UNKNOWN) {
                 _parseNumericValue(); // will also check event type
             }
-            if (_numberType == NumberType.DOUBLE) {
-                // 10-Mar-2017, tatu: Alas, `Double.isFinite(d)` only added in JDK 8
-                double d = _numberDouble;
-                return Double.isNaN(d) || Double.isInfinite(d);
+            if ((_numTypesValid & NR_DOUBLE) != 0) {
+                return !Double.isFinite(_numberDouble);
             }
-            if (_numberType == NumberType.FLOAT) {
-                float f = _numberFloat;
-                return Float.isNaN(f) || Float.isInfinite(f);
+            if ((_numTypesValid & NR_FLOAT) != 0) {
+                return !Float.isFinite(_numberFloat);
             }
         }
         return false;