More error reporting improvements to track down #1342

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/DeserializationContext.java

@@ -19,6 +19,7 @@
 import com.fasterxml.jackson.databind.exc.InvalidTypeIdException;
 import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
 import com.fasterxml.jackson.databind.introspect.Annotated;
+import com.fasterxml.jackson.databind.introspect.BeanPropertyDefinition;
 import com.fasterxml.jackson.databind.jsontype.TypeDeserializer;
 import com.fasterxml.jackson.databind.jsontype.TypeIdResolver;
 import com.fasterxml.jackson.databind.node.JsonNodeFactory;
@@ -1258,6 +1259,41 @@ public void reportUnresolvedObjectId(ObjectIdReader oidReader, Object bean)
         throw JsonMappingException.from(getParser(), msg);
     }
 
+    /**
+     * Helper method called to indicate problem in POJO (serialization) definitions or settings
+     * regarding specific Java type, unrelated to actual JSON content to map.
+     * Default behavior is to construct and throw a {@link JsonMappingException}.
+     *
+     * @since 2.9
+     */
+    public <T> T reportBadTypeDefinition(BeanDescription bean,
+            String message, Object... args) throws JsonMappingException {
+        if (args != null && args.length > 0) {
+            message = String.format(message, args);
+        }
+        String beanDesc = (bean == null) ? "N/A" : _desc(bean.getType().getGenericSignature());
+        throw mappingException("Invalid type definition for type %s: %s",
+                beanDesc, message);
+    }
+
+    /**
+     * Helper method called to indicate problem in POJO (serialization) definitions or settings
+     * regarding specific property (of a type), unrelated to actual JSON content to map.
+     * Default behavior is to construct and throw a {@link JsonMappingException}.
+     *
+     * @since 2.9
+     */
+    public <T> T reportBadPropertyDefinition(BeanDescription bean, BeanPropertyDefinition prop,
+            String message, Object... args) throws JsonMappingException {
+        if (args != null && args.length > 0) {
+            message = String.format(message, args);
+        }
+        String propName = (prop == null)  ? "N/A" : _quotedString(prop.getName());
+        String beanDesc = (bean == null) ? "N/A" : _desc(bean.getType().getGenericSignature());
+        throw mappingException("Invalid definition for property %s (of type %s): %s",
+                propName, beanDesc, message);
+    }
+
     /*
     /**********************************************************
     /* Methods for constructing exceptions, "untyped"

src/main/java/com/fasterxml/jackson/databind/MapperFeature.java

@@ -21,7 +21,7 @@ public enum MapperFeature implements ConfigFeature
     /* Introspection features
     /******************************************************
      */
-    
+
     /**
      * Feature that determines whether annotation introspection
      * is used for configuration; if enabled, configured

src/main/java/com/fasterxml/jackson/databind/SerializerProvider.java

@@ -1175,7 +1175,7 @@ public <T> T reportBadPropertyDefinition(BeanDescription bean, BeanPropertyDefin
         if (args != null && args.length > 0) {
             message = String.format(message, args);
         }
-        String propName = (prop == null)  ? "N/A" : _desc(prop.getName());
+        String propName = (prop == null)  ? "N/A" : _quotedString(prop.getName());
         String beanDesc = (bean == null) ? "N/A" : _desc(bean.getType().getGenericSignature());
         throw mappingException("Invalid definition for property %s (of type %s): %s",
                 propName, beanDesc, message);
@@ -1347,6 +1347,13 @@ protected String _desc(Object value) {
         return "'"+value+"'";
     }
 
+    protected String _quotedString(Object value) {
+        if (value == null) {
+            return "N/A";
+        }
+        return String.valueOf(value);
+    }
+
     protected final DateFormat _dateFormat()
     {
         if (_dateFormat != null) {

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerFactory.java

@@ -719,6 +719,12 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
     {
         // need to ensure method is callable (for non-public)
         AnnotatedMember mutator = propDef.getNonConstructorMutator();
+        // 08-Sep-2016, tatu: issues like [databind#1342] suggest something fishy
+        //   going on; add sanity checks to try to pin down actual problem...
+        //   Possibly passing creator parameter?
+        if (mutator == null) {
+            ctxt.reportBadPropertyDefinition(beanDesc, propDef, "No non-constructor mutator available");
+        }
         JavaType type = resolveMemberAndTypeAnnotations(ctxt, mutator, propType0);
         // Does the Method specify the deserializer to use? If so, let's use it.
         TypeDeserializer typeDeser = type.getTypeHandler();
@@ -727,6 +733,7 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
             prop = new MethodProperty(propDef, type, typeDeser,
                     beanDesc.getClassAnnotations(), (AnnotatedMethod) mutator);
         } else {
+            // 08-Sep-2016, tatu: wonder if we should verify it is `AnnotatedField` to be safe?
             prop = new FieldProperty(propDef, type, typeDeser,
                     beanDesc.getClassAnnotations(), (AnnotatedField) mutator);
         }