Skip to content

Commit b3f623f

Browse files
committed
Fix #1291
1 parent f7e476e commit b3f623f

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

release-notes/VERSION

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ Project: jackson-databind
1010
#1288: Type id not exposed for `JsonTypeInfo.As.EXTERNAL_PROPERTY` even when `visible` set to `true`
1111
(reported by libetl@github)
1212
#1289: Optimize construction of `ArrayList`, `LinkedHashMap` instances
13+
#1291: Backward-incompatible behaviour of 2.8: deserializing enum types
14+
with two static factory methods fail by default
1315

1416
2.8.0 (04-Jul-2016)
1517

src/test/java/com/fasterxml/jackson/failing/EnumCreator1291Test.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.fasterxml.jackson.failing;
22

3+
import com.fasterxml.jackson.annotation.JsonCreator;
34
import com.fasterxml.jackson.databind.BaseMapTest;
45
import com.fasterxml.jackson.databind.ObjectMapper;
56

@@ -20,6 +21,7 @@ static enum Enum1291 {
2021
this.name = name;
2122
}
2223

24+
// @JsonCreator
2325
public static Enum1291 fromString(String name) {
2426
for (Enum1291 type : Enum1291.values()) {
2527
if (type.name.equals(name)) {

src/test/java/com/fasterxml/jackson/failing/EnumCreatorTest929.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import com.fasterxml.jackson.annotation.JsonProperty;
55
import com.fasterxml.jackson.databind.*;
66

7+
// Ideally should allow multiple-parameter Creator; but not
8+
// yet allowed or supported
79
public class EnumCreatorTest929 extends BaseMapTest
810
{
911
static enum MyEnum

0 commit comments

Comments
 (0)