Fix #3682 (prune transient Fields from being mutators)

Author: cowtowncoder

release-notes/VERSION-2.x

@@ -8,6 +8,7 @@ Project: jackson-databind
 
 #3676: Allow use of `@JsonCreator(mode = Mode.PROPERTIES)` creator for POJOs
  with"empty String" coercion
+#3682: Transient `Field`s are not ignored as Mutators if there is visible Getter
 
 2.14.1 (21-Nov-2022)
 

src/main/java/com/fasterxml/jackson/databind/MapperFeature.java

@@ -53,7 +53,7 @@ public enum MapperFeature implements ConfigFeature
     /**
      * Feature that determines how <code>transient</code> modifier for fields
      * is handled: if disabled, it is only taken to mean exclusion of the field
-     * as accessor; if true, it is taken to imply removal of the whole property.
+     * as an accessor; if true, it is taken to imply removal of the whole property.
      *<p>
      * Feature is disabled by default, meaning that existence of `transient`
      * for a field does not necessarily lead to ignoral of getters or setters

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -582,9 +582,12 @@ protected void _addFields(Map<String, POJOPropertyBuilder> props)
                 // 20-May-2016, tatu: as per [databind#1184] explicit annotation should override
                 //    "default" `transient`
                 if (!hasName) {
-                    visible = false;
+                    // 25-Nov-2022, tatu: [databind#3682] Drop transient Fields early;
+                    //     only retain if also have ignoral annotations (for name or ignoral)
                     if (transientAsIgnoral) {
                         ignored = true;
+                    } else {
+                        continue;
                     }
                 }
             }

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertyBuilder.java

@@ -950,7 +950,7 @@ public JsonProperty.Access removeNonVisible(boolean inferMutators,
         case AUTO: // the default case: base it on visibility
             _getters = _removeNonVisible(_getters);
             _ctorParameters = _removeNonVisible(_ctorParameters);
-    
+
             if (!inferMutators || (_getters == null)) {
                 _fields = _removeNonVisible(_fields);
                 _setters = _removeNonVisible(_setters);

src/test/java/com/fasterxml/jackson/databind/format/CollectionFormatShapeTest.java

@@ -55,5 +55,4 @@ public void testListAsObjectRoundtrip() throws Exception
         CollectionAsPOJO result = MAPPER.readValue(json, CollectionAsPOJO.class);
         assertEquals(2, result.size());
     }
-
 }

src/test/java/com/fasterxml/jackson/databind/introspect/TransientTest.java

@@ -5,6 +5,7 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.annotation.JsonPropertyOrder;
 import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
 
 /**
  * Tests for both `transient` keyword and JDK 7
@@ -45,6 +46,12 @@ static class OverridableTransient {
         public OverridableTransient(int v) { tValue = v; }
     }
 
+    static class TransientToPrune {
+        public transient int a;
+
+        public int getA() { return a; }
+    }
+
     /*
     /**********************************************************
     /* Unit tests
@@ -83,4 +90,16 @@ public void testOverridingTransient() throws Exception
         assertEquals(a2q("{'tValue':38}"),
                 MAPPER.writeValueAsString(new OverridableTransient(38)));
     }
+
+    // for [databind#3682]: SHOULD prune `transient` Field, not pull in
+    public void testTransientToPrune() throws Exception
+    {
+        try {
+            TransientToPrune result = MAPPER.readValue("{\"a\":3}",
+                    TransientToPrune.class);
+            fail("Should not pass, got: "+result);
+        } catch (UnrecognizedPropertyException e) {
+            verifyException(e, "Unrecognized", "\"a\"");
+        }
+    }
 }