Add StreamReadConstraints for TokenBuffer (#3691)

Author: pjfanning

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerBase.java

@@ -1357,7 +1357,7 @@ protected Object _convertObjectId(JsonParser p, DeserializationContext ctxt,
             //   but that won't work for default impl (JSON and most dataformats)
             buf.writeObject(rawId);
         }
-        JsonParser bufParser = buf.asParser();
+        JsonParser bufParser = buf.asParser(p.streamReadConstraints());
         bufParser.nextToken();
         return idDeser.deserialize(bufParser, ctxt);
     }
@@ -1746,7 +1746,7 @@ protected Object handlePolymorphic(JsonParser p, DeserializationContext ctxt,
             if (unknownTokens != null) {
                 // need to add END_OBJECT marker first
                 unknownTokens.writeEndObject();
-                JsonParser p2 = unknownTokens.asParser();
+                JsonParser p2 = unknownTokens.asParser(p.streamReadConstraints());
                 p2.nextToken(); // to get to first data field
                 bean = subDeser.deserialize(p2, ctxt, bean);
             }

src/main/java/com/fasterxml/jackson/databind/deser/impl/UnwrappedPropertyHandler.java

@@ -57,7 +57,7 @@ public Object processUnwrapped(JsonParser originalParser, DeserializationContext
     {
         for (int i = 0, len = _properties.size(); i < len; ++i) {
             SettableBeanProperty prop = _properties.get(i);
-            JsonParser p = buffered.asParser();
+            JsonParser p = buffered.asParser(originalParser.streamReadConstraints());
             p.nextToken();
             prop.deserializeAndSet(p, ctxt, bean);
         }

src/main/java/com/fasterxml/jackson/databind/util/TokenBuffer.java

@@ -58,6 +58,11 @@ public class TokenBuffer
      */
     protected int _generatorFeatures;
 
+    /**
+     * @since 2.15
+     */
+    protected StreamReadConstraints _streamReadConstraints = StreamReadConstraints.defaults();
+
     protected boolean _closed;
 
     /**
@@ -170,6 +175,7 @@ public TokenBuffer(JsonParser p) {
     public TokenBuffer(JsonParser p, DeserializationContext ctxt)
     {
         _objectCodec = p.getCodec();
+        _streamReadConstraints = p.streamReadConstraints();
         _parentContext = p.getParsingContext();
         _generatorFeatures = DEFAULT_GENERATOR_FEATURES;
         _writeContext = JsonWriteContext.createRootContext(null);
@@ -273,16 +279,26 @@ public JsonParser asParserOnFirstToken() throws IOException {
      */
     public JsonParser asParser(ObjectCodec codec)
     {
-        return new Parser(_first, codec, _hasNativeTypeIds, _hasNativeObjectIds, _parentContext);
+        return new Parser(_first, codec, _hasNativeTypeIds, _hasNativeObjectIds, _parentContext, _streamReadConstraints);
+    }
+
+    /**
+     * @param streamReadConstraints constraints for streaming reads
+     * @since v2.15
+     */
+    public JsonParser asParser(StreamReadConstraints streamReadConstraints)
+    {
+        return new Parser(_first, _objectCodec, _hasNativeTypeIds, _hasNativeObjectIds, _parentContext, streamReadConstraints);
     }
 
     /**
      * @param src Parser to use for accessing source information
-     *    like location, configured codec
+     *    like location, configured codec, streamReadConstraints
      */
     public JsonParser asParser(JsonParser src)
     {
-        Parser p = new Parser(_first, src.getCodec(), _hasNativeTypeIds, _hasNativeObjectIds, _parentContext);
+        Parser p = new Parser(_first, src.getCodec(), _hasNativeTypeIds, _hasNativeObjectIds,
+                _parentContext, src.streamReadConstraints());
         p.setLocation(src.getTokenLocation());
         return p;
     }
@@ -1441,6 +1457,11 @@ protected final static class Parser
 
         protected ObjectCodec _codec;
 
+        /**
+         * @since 2.15
+         */
+        protected StreamReadConstraints _streamReadConstraints;
+
         /**
          * @since 2.3
          */
@@ -1493,10 +1514,18 @@ public Parser(Segment firstSeg, ObjectCodec codec,
         {
             this(firstSeg, codec, hasNativeTypeIds, hasNativeObjectIds, null);
         }
-        
+
+        @Deprecated // since 2.15
+        public Parser(Segment firstSeg, ObjectCodec codec,
+                      boolean hasNativeTypeIds, boolean hasNativeObjectIds,
+                      JsonStreamContext parentContext)
+        {
+            this(firstSeg, codec, hasNativeTypeIds, hasNativeObjectIds, parentContext, StreamReadConstraints.defaults());
+        }
+
         public Parser(Segment firstSeg, ObjectCodec codec,
                 boolean hasNativeTypeIds, boolean hasNativeObjectIds,
-                JsonStreamContext parentContext)
+                JsonStreamContext parentContext, StreamReadConstraints streamReadConstraints)
         {
             // 25-Jun-2022, tatu: Ideally would pass parser flags along (as
             //    per [databund#3528]) but for now make sure not to clear the flags
@@ -1505,6 +1534,7 @@ public Parser(Segment firstSeg, ObjectCodec codec,
             _segment = firstSeg;
             _segmentPtr = -1; // not yet read
             _codec = codec;
+            _streamReadConstraints = streamReadConstraints;
             _parsingContext = TokenBufferReadContext.createRootContext(parentContext);
             _hasNativeTypeIds = hasNativeTypeIds;
             _hasNativeObjectIds = hasNativeObjectIds;
@@ -1541,11 +1571,9 @@ public JacksonFeatureSet<StreamReadCapability> getReadCapabilities() {
             return DEFAULT_READ_CAPABILITIES;
         }
 
-        // 03-Dec-2022, tatu: Not 100% sure what to do here; could probably instead
-        //    pass from somewhere?
         @Override
         public StreamReadConstraints streamReadConstraints() {
-            return StreamReadConstraints.defaults();
+            return _streamReadConstraints;
         }
 
         /*

src/test/java/com/fasterxml/jackson/databind/deser/TestBigNumbers.java

@@ -48,7 +48,7 @@ public void setNumber(BigInteger number) {
 
     private final ObjectMapper MAPPER = newJsonMapper();
 
-    private final ObjectMapper newJsonMapperWithUnlimitedNumberSizeSupport() {
+    private ObjectMapper newJsonMapperWithUnlimitedNumberSizeSupport() {
         JsonFactory jsonFactory = JsonFactory.builder()
                 .streamReadConstraints(StreamReadConstraints.builder().maxNumberLength(Integer.MAX_VALUE).build())
                 .build();
@@ -59,6 +59,7 @@ public void testDouble() throws Exception
     {
         try {
             MAPPER.readValue(generateJson("d"), DoubleWrapper.class);
+            fail("expected JsonMappingException");
         } catch (JsonMappingException jsonMappingException) {
             assertTrue("unexpected exception message: " + jsonMappingException.getMessage(),
                     jsonMappingException.getMessage().startsWith("Malformed numeric value ([number with 1200 characters])"));
@@ -76,6 +77,7 @@ public void testBigDecimal() throws Exception
     {
         try {
             MAPPER.readValue(generateJson("number"), BigDecimalWrapper.class);
+            fail("expected JsonMappingException");
         } catch (JsonMappingException jsonMappingException) {
             assertTrue("unexpected exception message: " + jsonMappingException.getMessage(),
                     jsonMappingException.getMessage().startsWith("Malformed numeric value ([number with 1200 characters])"));
@@ -94,6 +96,7 @@ public void testBigInteger() throws Exception
     {
         try {
             MAPPER.readValue(generateJson("number"), BigIntegerWrapper.class);
+            fail("expected JsonMappingException");
         } catch (JsonMappingException jsonMappingException) {
             assertTrue("unexpected exception message: " + jsonMappingException.getMessage(),
                     jsonMappingException.getMessage().startsWith("Malformed numeric value ([number with 1200 characters])"));