Skip to content

Commit c1f5462

Browse files
authored
Fix #838: Add Android SDK compatibility check with AnimalSniffer (#841)
1 parent 56c3716 commit c1f5462

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ jobs:
5151
- name: Extract project Maven version
5252
id: projectVersion
5353
run: echo ::set-output name=version::$(./mvnw org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate -DforceStdout -Dexpression=project.version -q)
54+
- name: Verify Android SDK Compatibility
55+
if: matrix.java_version == '8'
56+
run: ./mvnw -B -q -ff -ntp -DskipTests animal-sniffer:check
5457
- name: Deploy snapshot
5558
if: github.event_name != 'pull_request' && matrix.java_version == '8' && endsWith(steps.projectVersion.outputs.version, '-SNAPSHOT')
5659
env:

pom.xml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,13 @@
4343
<maven.compiler.source>1.6</maven.compiler.source>
4444
<maven.compiler.target>1.6</maven.compiler.target>
4545

46+
<!-- 16-Nov-2022, tatu: [core#838] Verify Android SDK compatibility.
47+
Baseline compatibility:
48+
* Jackson 2.13 compatible with Android SDK 19 and up
49+
-->
50+
<version.android.sdk>19</version.android.sdk>
51+
<version.android.sdk.signature>0.5.0</version.android.sdk.signature>
52+
4653
<osgi.export>com.fasterxml.jackson.core;version=${project.version},
4754
com.fasterxml.jackson.core.*;version=${project.version}
4855
</osgi.export>
@@ -142,6 +149,24 @@ com.fasterxml.jackson.core.*;version=${project.version}
142149
<groupId>de.jjohannes</groupId>
143150
<artifactId>gradle-module-metadata-maven-plugin</artifactId>
144151
</plugin>
152+
153+
<!-- 16-Nov-2022, tatu: [core#838] add verification of compatibility
154+
wrt Android SDK versions using AnimalSniffer with "gummy bears" signatures.
155+
To be run from CI, but manually with:
156+
mvn clean package animal-sniffer:check
157+
-->
158+
<plugin>
159+
<groupId>org.codehaus.mojo</groupId>
160+
<artifactId>animal-sniffer-maven-plugin</artifactId>
161+
<version>1.22</version>
162+
<configuration>
163+
<signature>
164+
<groupId>com.toasttab.android</groupId>
165+
<artifactId>gummy-bears-api-${version.android.sdk}</artifactId>
166+
<version>${version.android.sdk.signature}</version>
167+
</signature>
168+
</configuration>
169+
</plugin>
145170
</plugins>
146171
</build>
147172

0 commit comments

Comments
 (0)