additional endpoint test

Author: swilly22

README.md

@@ -1,8 +1,9 @@
+flask --app code_graph run --debug
+
 Process local git repository, ignoring specific folder(s)
 
 curl -X POST http://127.0.0.1:5000/process_local_repo -H "Content-Type: application/json" -d '{"repo": "/Users/roilipman/Dev/FalkorDB", "ignore": ["./.github", "./sbin", "./.git","./deps", "./bin", "./build"]}'
 
-
 Process code coverage
 curl -X POST http://127.0.0.1:5000/process_code_coverage -H "Content-Type: application/json" -d '{"lcov": "/Users/roilipman/Dev/code_graph/code_graph/code_coverage/lcov/falkordb.lcov", "repo": "FalkorDB"}'
 

code_graph/app.py

@@ -420,11 +420,19 @@ def find_paths():
         src = data.get('src')
         if src is None:
             return jsonify({'status': f'Missing mandatory parameter "src"'}), 400
+        if not isinstance(src, int):
+            return jsonify({'status': "src node id must be int"}), 400
 
         # Validate 'dest' parameter
         dest = data.get('dest')
         if dest is None:
             return jsonify({'status': f'Missing mandatory parameter "dest"'}), 400
+        if not isinstance(dest, int):
+            return jsonify({'status': "dest node id must be int"}), 400
+
+        if not graph_exists(repo):
+            logging.error(f"Missing project {repo}")
+            return jsonify({"status": f"Missing project {repo}"}), 400
 
         # Initialize graph with provided repo and credentials
         g = Graph(repo)

code_graph/graph.py

@@ -722,7 +722,18 @@ def find_paths(self, src: int, dest: int) -> List[Path]:
 
         # Extract paths from the query result set.
         for row in result_set:
-            paths.append(row[0])
+            path  = []
+            p     = row[0]
+            nodes = p.nodes()
+            edges = p.edges()
+
+            for n, e in zip(nodes, edges):
+                path.append(encode_node(n))
+                path.append(encode_edge(e))
+
+            # encode last node on path
+            path.append(encode_node(nodes[-1]))
+            paths.append(path)
 
         return paths
 

tests/endpoints/test_find_paths.py

@@ -0,0 +1,80 @@
+import os
+import redis
+import pytest
+from pathlib import Path
+from code_graph import create_app, Project
+from falkordb import FalkorDB, Path, Node, QueryResult
+
+@pytest.fixture()
+def app():
+    app = create_app()
+    app.config.update({
+        "TESTING": True,
+    })
+
+    # other setup can go here
+    redis.Redis().flushall()
+
+    yield app
+
+    # clean up / reset resources here
+
+@pytest.fixture()
+def client(app):
+    return app.test_client()
+
+@pytest.fixture()
+def runner(app):
+    return app.test_cli_runner()
+
+def test_find_paths(client):
+    # Start with an empty DB
+    response = client.post("/find_paths", json={"repo": "GraphRAG-SDK", "src": 0, "dest": 0}).json
+    status   = response["status"] 
+
+    # Expecting an error
+    assert status == "Missing project GraphRAG-SDK"
+
+    # Process Git repository
+    proj = Project.from_git_repository("https://github.com/FalkorDB/GraphRAG-SDK")
+    proj.analyze_sources()
+
+    # Re-issue with invalid src node id
+    response = client.post("/find_paths", json={"repo": "GraphRAG-SDK", "src": 'invalid', "dest": 0}).json
+    status   = response["status"]
+    assert status == "src node id must be int"
+
+    # Re-issue with invalid dest node id
+    response = client.post("/find_paths", json={"repo": "GraphRAG-SDK", "src": 0, "dest": 'invalid'}).json
+    status   = response["status"]
+    assert status == "dest node id must be int"
+
+    # Find src and dest nodes that are at least 3 hops apart
+    db = FalkorDB(host=os.getenv('FALKORDB_HOST', 'localhost'),
+                  port=os.getenv('FALKORDB_PORT', 6379),
+                  username=os.getenv('FALKORDB_USERNAME', None),
+                  password=os.getenv('FALKORDB_PASSWORD', None))
+    g = db.select_graph("GraphRAG-SDK")
+    q = """MATCH (a:Function)-[:CALLS*3..5]->(b:Function)
+           RETURN ID(a), ID(b)
+           LIMIT 1"""
+
+    result_set = g.query(q).result_set
+    src_id     = result_set[0][0]
+    dest_id    = result_set[0][1]
+
+    # Re-issue with none existing node id
+    response = client.post("/find_paths", json={
+        "repo": "GraphRAG-SDK",
+        "src": src_id,
+        "dest": dest_id}).json
+
+    status = response["status"]
+    paths  = response["paths"]
+
+    for p in paths:
+        assert p[0]['id']  == src_id
+        assert p[-1]['id'] == dest_id
+        assert len(p) % 2 == 1
+        assert len(p) >= 3
+

tests/test_c_analyzer.py

@@ -2,7 +2,7 @@
 import unittest
 from pathlib import Path
 
-from code_graph import SourceAnalyzer, File, Struct, Function
+from code_graph import SourceAnalyzer, File, Struct, Function, Graph
 
 class Test_C_Analyzer(unittest.TestCase):
     def test_analyzer(self):
@@ -20,10 +20,11 @@ def test_analyzer(self):
         path = os.path.join(path, 'c')
         path = str(path)
 
-        g = analyzer.analyze_local_folder(path)
+        g = Graph("c")
+        analyzer.analyze(path, g)
 
-        f = g.get_file('.', 'src.c', '.c')
-        self.assertEqual(File('.', 'src.c', '.c'), f)
+        f = g.get_file('', 'src.c', '.c')
+        self.assertEqual(File('', 'src.c', '.c'), f)
 
         s = g.get_struct_by_name('exp')
         expected_s = Struct('src.c', 'exp', '', 9, 13)

tests/test_py_analyzer.py

@@ -2,7 +2,7 @@
 import unittest
 from pathlib import Path
 
-from code_graph import SourceAnalyzer, File, Class, Function
+from code_graph import SourceAnalyzer, File, Class, Function, Graph
 
 class Test_PY_Analyzer(unittest.TestCase):
     def test_analyzer(self):
@@ -20,10 +20,11 @@ def test_analyzer(self):
         path = os.path.join(path, 'py')
         path = str(path)
 
-        g = analyzer.analyze_local_folder(str(path))
+        g = Graph("py")
+        analyzer.analyze(path, g)
 
-        f = g.get_file('.', 'src.py', '.py')
-        self.assertEqual(File('.', 'src.py', '.py'), f)
+        f = g.get_file('', 'src.py', '.py')
+        self.assertEqual(File('', 'src.py', '.py'), f)
 
         log = g.get_function_by_name('log')
         expected_log = Function('src.py', 'log', None, 'None', '', 0, 1)