New burning affliction needs tweaks

[ubertpendragon]

The new burning affliction needs a few changes.

• People catch on fire and fire goes away too quickly with no buildup
• Smoke particle entirely hides the character (+ particle spam)

This is one press of LMB with the flamer, the NPCs catch on fire immediately and are extinguished a second later.

Desktop.2023.09.10.-.17.38.09.06_66.mp4

Divide burning in 3 phases:

0-5 Buildup, you don't burn fully yet, prevents lighting on fire for a microsecond if sprayed with a flamer

5-10 Burning (temporary), you are actually burning

10-15 Burning (A LOT), past this point the fire goes out much more slowly

  <Affliction name="Burning" identifier="burning" description="The target is burning." type="burn" causeofdeathdescription="" selfcauseofdeathdescription="" limbspecific="true" activationthreshold="1.0" showiconthreshold="1000" maxstrength="15">
    <!-- A buildup for burning, you don't burn yet until reaching 5 -->
    <Effect minstrength="0" maxstrength="5" minvitalitydecrease="0" maxvitalitydecrease="0" strengthchange="-1.0">
      <StatusEffect target="Limb" disabledeltatime="true">
        <ReduceAffliction identifier="burning" amount="7.5" />
        <Conditional InWater="true" />
      </StatusEffect>
    </Effect>
    <!-- You actively start burning here -->
    <Effect minstrength="5" maxstrength="10" minvitalitydecrease="0" maxvitalitydecrease="0" strengthchange="-1.0">
      <StatusEffect target="Limb">
        <ParticleEmitter particle="flameburningcharacter" DistanceMin="0" DistanceMax="30" ParticlesPerSecond="200" AngleMin="60" AngleMax="120" VelocityMax="20"/>
        <ParticleEmitter particle="smoke" particlespersecond="6" scalemin="4" scalemax="3" distancemin="10" distancemax="50" />
        <Affliction identifier="burn" amount="0.6" />
        <Conditional InWater="false" />
      </StatusEffect>
      <StatusEffect target="Limb" disabledeltatime="true">
        <ReduceAffliction identifier="burning" amount="7.5" />
        <Conditional InWater="true" />
      </StatusEffect>
      <StatusEffect target="Character">
        <sound file="Content/Sounds/FireSmall.ogg" range="200.0" />
        <Conditional InWater="false" />
      </StatusEffect>
    </Effect>
    <!-- Past 10, you've fully caught on fire and burning reduces at a much slower rate -->
    <Effect minstrength="10" maxstrength="15" minvitalitydecrease="0" maxvitalitydecrease="0" strengthchange="-0.2">
      <StatusEffect target="Limb">
        <ParticleEmitter particle="flameburningcharacter" DistanceMin="0" DistanceMax="30" ParticlesPerSecond="200" AngleMin="60" AngleMax="120" VelocityMax="20"/>
        <ParticleEmitter particle="smoke" particlespersecond="6" scalemin="4" scalemax="3" distancemin="10" distancemax="50" />
        <Affliction identifier="burn" amount="0.6" />
        <Conditional InWater="false" />
      </StatusEffect>
      <StatusEffect target="Limb" disabledeltatime="true">
        <ReduceAffliction identifier="burning" amount="7.5" />
        <Conditional InWater="true" />
      </StatusEffect>
      <StatusEffect target="Character">
        <sound file="Content/Sounds/FireSmall.ogg" range="200.0" />
        <Conditional InWater="false" />
      </StatusEffect>
    </Effect>
    <icon texture="Content/UI/MainIconsAtlas.png" sourcerect="768,640,128,128" color="195,0,0,255" origin="0,0" />
  </Affliction>

[ubertpendragon]

posted video

[Regalis11]

This has been addressed in our private repo now, fixes are included in the current unstable build.