Updating SwiftLint to 0.35.0

Author: FabrizioBrancati

.swiftlint.yml

@@ -9,8 +9,11 @@ opt_in_rules:
   - closure_end_indentation
   - closure_spacing
   - conditional_returns_on_newline
+  - contains_over_filter_count
+  - contains_over_filter_is_empty
   - contains_over_first_not_nil
   - convenience_type
+  - empty_collection_literal
   - empty_count
   - empty_string
   - empty_xctest_method
@@ -20,11 +23,13 @@ opt_in_rules:
   - fatal_error_message
   - file_name
   - file_header
+  - file_types_order
   - first_where
   - force_unwrapping
   - implicitly_unwrapped_optional
   - joined_default_parameter
   - last_where
+  - legacy_multiple
   - let_var_whitespace
   - literal_expression_end_indentation
   - lower_acl_than_parent
@@ -51,6 +56,7 @@ opt_in_rules:
   - quick_discouraged_call
   - quick_discouraged_focused_test
   - quick_discouraged_pending_test
+  - reduce_into
   - redundant_nil_coalescing
   - single_test_class
   - sorted_first_last
@@ -59,6 +65,7 @@ opt_in_rules:
   - trailing_closure
   - unavailable_function
   - unneeded_parentheses_in_closure_argument
+  - unowned_variable_capture
   - untyped_error_in_catch
   - vertical_parameter_alignment_on_call
   - vertical_whitespace_between_cases
@@ -84,7 +91,7 @@ file_header:
                     \/\/
                     \/\/  The MIT License \(MIT\)
                     \/\/
-                    \/\/  Copyright \(c\) 2015 - 2018 Fabrizio Brancati\.
+                    \/\/  Copyright \(c\) 2015 - 2019 Fabrizio Brancati\.
                     \/\/
                     \/\/  Permission is hereby granted, free of charge, to any person obtaining a copy
                     \/\/  of this software and associated documentation files \(the "Software"\), to deal

BFKit-Swift.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
   s.name              = 'BFKit-Swift'
   s.module_name       = 'BFKit'
-  s.version           = '5.0.0'
+  s.version           = '6.0.0'
   s.summary           = 'BFKit-Swift is a collection of useful classes, structs and extensions to develop Apps faster.'
   s.homepage          = 'https://github.com/FabrizioBrancati/BFKit-Swift'
   s.screenshots       = 'https://github.fabriziobrancati.com/bfkit/resources/screenshot-swift.png'

BFKit.xcodeproj/project.pbxproj

@@ -1054,7 +1054,7 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CODE_SIGN_IDENTITY = "";
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 6.0.0;
 				DEFINES_MODULE = YES;
 				DEVELOPMENT_TEAM = "";
 				DYLIB_COMPATIBILITY_VERSION = 1;
@@ -1083,7 +1083,7 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CODE_SIGN_IDENTITY = "";
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 6.0.0;
 				DEFINES_MODULE = YES;
 				DEVELOPMENT_TEAM = "";
 				DYLIB_COMPATIBILITY_VERSION = 1;
@@ -1232,7 +1232,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 5.0.0;
+				CURRENT_PROJECT_VERSION = 6.0.0;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
@@ -1296,7 +1296,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 5.0.0;
+				CURRENT_PROJECT_VERSION = 6.0.0;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;

CHANGELOG.md

@@ -59,6 +59,9 @@ All notable changes to this project will be documented in this file.<br>
 - Removed support to UIWebView [#44](https://github.com/FabrizioBrancati/BFKit-Swift/pull/44)
 - Removed `isURLValid` on Linux
 
+### Improved
+- Updated SwiftLint to 0.35.0
+
 Thanks to [@Tripwire999](https://github.com/Tripwire999) for this release
 
 ---

Example/BFKitExample/Info.plist

@@ -17,7 +17,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

Sources/BFKit/Apple/BFKit/BFButton.swift

@@ -47,7 +47,8 @@ open class BFButton: UIButton {
                 }
             } else {
                 UIView.animate(
-                    withDuration: fadeDuration, animations: { [weak self] in
+                    withDuration: fadeDuration,
+                    animations: { [weak self] in
                         self?.overlayImageView.alpha = 0
                     }, completion: { [weak self] completed in
                         if completed {

Sources/BFKit/Apple/BFKit/BFTextField.swift

@@ -50,15 +50,6 @@ open class BFTextField: UITextField {
         NotificationCenter.default.addObserver(self, selector: #selector(BFTextField.textFieldDidChange(_:)), name: UITextField.textDidChangeNotification, object: self)
     }
 
-    /// Encodes added variables.
-    ///
-    /// - Parameter aCoder: NSCoder.
-    override open func encode(with aCoder: NSCoder) {
-        super.encode(with: aCoder)
-        
-        aCoder.encode(maxNumberOfCharacters, forKey: "MaxNumberOfCharacters")
-    }
-    
     /// Override init with frame.
     ///
     /// - Parameter frame: TextField frame.
@@ -69,6 +60,15 @@ open class BFTextField: UITextField {
         NotificationCenter.default.addObserver(self, selector: #selector(BFTextField.textFieldDidChange(_:)), name: UITextField.textDidChangeNotification, object: self)
     }
 
+    /// Encodes added variables.
+    ///
+    /// - Parameter aCoder: NSCoder.
+    override open func encode(with aCoder: NSCoder) {
+        super.encode(with: aCoder)
+        
+        aCoder.encode(maxNumberOfCharacters, forKey: "MaxNumberOfCharacters")
+    }
+    
     @objc
     /// Text field did change function.
     ///

Sources/BFKit/Apple/UIKit/UITableView+Extensions.swift

@@ -56,7 +56,7 @@ public extension UITableView {
     /// - Returns: Returns the next index path.
     func nextIndexPath(row: Int, forSection section: Int) -> IndexPath? {
         let indexPath: [IndexPath] = indexPaths(section: section)
-        guard indexPath != [] else {
+        guard indexPath.isNotEmpty else {
             return nil
         }
 
@@ -71,7 +71,7 @@ public extension UITableView {
     /// - Returns: Returns the previous index path.
     func previousIndexPath(row: Int, forSection section: Int) -> IndexPath? {
         let indexPath: [IndexPath] = indexPaths(section: section)
-        guard indexPath != [] else {
+        guard indexPath.isNotEmpty else {
             return nil
         }
 

Sources/BFKit/Apple/UIKit/UIView+Extensions.swift

@@ -36,51 +36,48 @@ public extension UIView {
     // MARK: - Variables
 
     /// Direction of flip animation.
-    ///
-    /// - top: Flip animation from top.
-    /// - left: Flip animation from left.
-    /// - right: Flip animation from right.
-    /// - bottom: Flip animation from bottom.
     enum UIViewAnimationFlipDirection: String {
+        /// Flip animation from top.
         case top = "fromTop"
+        /// Flip animation from left.
         case left = "fromLeft"
+        /// Flip animation from right.
         case right = "fromRight"
+        /// Flip animation from bottom.
         case bottom = "fromBottom"
     }
 
     /// Direction of the translation.
-    ///
-    /// - leftToRight: Translation from left to right.
-    /// - rightToLeft: Translation from right to left.
     enum UIViewAnimationTranslationDirection: Int {
+        /// Translation from left to right.
         case leftToRight
+        /// Translation from right to left.
         case rightToLeft
     }
 
     /// Direction of the linear gradient.
-    ///
-    /// - vertical: Linear gradient vertical.
-    /// - horizontal: Linear gradient horizontal.
-    /// - diagonalLeftToRightAndTopToDown: Linear gradient from left top to right down.
-    /// - diagonalLeftToRightAndDownToTop: Linear gradient from left down to right top.
-    /// - diagonalRightToLeftAndTopToDown: Linear gradient from right top to left down.
-    /// - diagonalRightToLeftAndDownToTop: Linear gradient from right down to left top.
     enum UIViewGradientDirection {
+        /// Linear gradient vertical.
         case vertical
+        /// Linear gradient horizontal.
         case horizontal
+        /// Linear gradient from left top to right down.
         case diagonalLeftTopToRightDown
+        /// Linear gradient from left down to right top.
         case diagonalLeftDownToRightTop
+        /// Linear gradient from right top to left down.
         case diagonalRightTopToLeftDown
+        ///  Linear gradient from right down to left top.
         case diagonalRightDownToLeftTop
+        /// Custom gradient direction.
         case custom(startPoint: CGPoint, endPoint: CGPoint)
     }
 
     /// Type of gradient.
-    ///
-    /// - linear: Linear gradient.
-    /// - radial: Radial gradient.
     enum UIViewGradientType {
+        /// Linear gradient.
         case linear
+        /// Radial gradient.
         case radial
     }
 
@@ -498,12 +495,18 @@ public extension UIView {
         }
 
         UIView.animate(
-            withDuration: TimeInterval(duration / 2), delay: 1, options: UIView.AnimationOptions(), animations: {
+            withDuration: TimeInterval(duration / 2),
+            delay: 1,
+            options: UIView.AnimationOptions(),
+            animations: {
                 self.center = CGPoint(x: endPosition, y: self.center.y)
             }, completion: { finished in
                 if finished {
                     UIView.animate(
-                        withDuration: TimeInterval(duration / 2), delay: 1, options: UIView.AnimationOptions(), animations: {
+                        withDuration: TimeInterval(duration / 2),
+                        delay: 1,
+                        options: UIView.AnimationOptions(),
+                        animations: {
                             self.center = CGPoint(x: startPosition, y: self.center.y)
                         }, completion: { finished in
                             if finished {

Sources/BFKit/Apple/UIKit/UIViewController+Extensions.swift

@@ -39,7 +39,8 @@ public extension UIViewController {
 
         if let coordinator = transitionCoordinator {
             coordinator.animateAlongsideTransition(
-                in: parent?.view, animation: { coordinatorContext in
+                in: parent?.view,
+                animation: { coordinatorContext in
                     selectedIndexPaths.forEach {
                         tableView.deselectRow(at: $0, animated: coordinatorContext.isAnimated)
                     }

Sources/BFKit/Apple/UIKit/UIWindow+Extensions.swift

@@ -204,7 +204,8 @@ public extension UIWindow {
             case .ended, .cancelled:
                 if let touchImageView = touchImages[touch.hash] {
                     UIView.animate(
-                        withDuration: 0.2, animations: {
+                        withDuration: 0.2,
+                        animations: {
                             touchImageView.alpha = 0.0
                             touchImageView.transform = CGAffineTransform(scaleX: 1.2, y: 1.2)
                         }, completion: { finished -> Void in

Sources/Info-iOS.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

Sources/Info-macOS.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>NSHumanReadableCopyright</key>

Sources/Info-watchOS.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

Tests/Info-iOS.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>

Tests/Info-macOS.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>5.0.0</string>
+	<string>6.0.0</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 </dict>

install_swiftlint.sh

@@ -7,7 +7,7 @@
 set -e
 
 SWIFTLINT_PKG_PATH="/tmp/SwiftLint.pkg"
-SWIFTLINT_PKG_URL="https://github.com/realm/SwiftLint/releases/download/0.31.0/SwiftLint.pkg"
+SWIFTLINT_PKG_URL="https://github.com/realm/SwiftLint/releases/download/0.35.0/SwiftLint.pkg"
 
 wget --output-document=$SWIFTLINT_PKG_PATH $SWIFTLINT_PKG_URL
 

jazzy.sh

@@ -2,7 +2,7 @@
 
 # Creates documentation using Jazzy.
 
-FRAMEWORK_VERSION=5.0.0
+FRAMEWORK_VERSION=6.0.0
 
 jazzy \
   --clean \