fix: download call signature

fix: download template bbox

Author: xgui3783

api/common/data_handlers/compounds/download.py

@@ -8,8 +8,7 @@
 import json
 import math
 
-BIGBRAIN_ID = "minds/core/referencespace/v1.0.0/a1655b99-82f1-420f-a3c2-fe80fd4c8588"
-BIGBRAIN_SIZE_LIMIT = 2 * 1024 * 1024
+VOLUME_SIZE_LIMIT = 2 * 1024 * 1024
 
 README = """# Packaged Atlas Data
 
@@ -138,17 +137,13 @@ def write_desc(filename, obj, **kwargs):
                 space: _space.Space = siibra.spaces[space_id]
                 space_filename = f"{space.key}.nii.gz"
 
-                # this should fetch anything (surface, nifti, ng precomputed)
-                if space.id == BIGBRAIN_ID:
-                    if bbox:
-                        bounding_box = space.get_bounding_box(*json.loads(bbox))
-                        value = BIGBRAIN_SIZE_LIMIT
-                        for dim in bounding_box.maxpoint - bounding_box.minpoint:
-                            value /= dim
-                        cube_rooted = math.pow(value, 1/3)
-                        space_vol = space.get_template().fetch(voi=bounding_box, resolution_mm=1/cube_rooted)
-                    else:
-                        raise RuntimeError(f"For big brain, bbox must be defined.")
+                if bbox:
+                    bounding_box = space.get_bounding_box(*json.loads(bbox))
+                    value = VOLUME_SIZE_LIMIT
+                    for dim in bounding_box.maxpoint - bounding_box.minpoint:
+                        value /= dim
+                    cube_rooted = math.pow(value, 1/3)
+                    space_vol = space.get_template().fetch(voi=bounding_box, resolution_mm=1/cube_rooted)
                 else:
                     space_vol = space.get_template().fetch()
                 zipfile.writestr(space_filename, gzip.compress(space_vol.to_bytes()))

api/server/compounds/download.py

@@ -25,7 +25,7 @@ def cleanup(filepath: Path):
 @router.get("")
 @version(*FASTAPI_VERSION)
 @router_decorator(ROLE, func=download_all, queue_as_async=(ROLE=="server"))
-def get_download_bundle(space_id: str=None, parcellation_id: str=None, bbox=None, region_id: str=None, feature_id: str=None, *, background: BackgroundTasks, func):
+def get_download_bundle(space_id: str=None, parcellation_id: str=None, bbox: str=None, region_id: str=None, feature_id: str=None, *, background: BackgroundTasks, func):
     """Prepare the bundle. Given a specification, prepare/bundle according to the specification."""
     returnval = func(space_id=space_id, parcellation_id=parcellation_id, bbox=bbox, region_id=region_id, feature_id=feature_id)
     try: