chore: more error handling (no unwraps, only expects in codepath's that cannot fail)

Author: filipton

build.rs

@@ -23,7 +23,7 @@ fn main() {
     } else {
         let epoch = std::time::SystemTime::now()
             .duration_since(std::time::UNIX_EPOCH)
-            .unwrap()
+            .expect("Cannot fail? (Getting epoch)")
             .as_secs();
 
         format!("D{epoch}")
@@ -37,6 +37,11 @@ fn main() {
         .replace("{hw}", hw)
         .replace("{firmware}", "STATION");
 
-    let out_dir = PathBuf::from(std::env::var("OUT_DIR").unwrap());
-    std::fs::write(out_dir.join("version.rs"), generated.trim()).unwrap();
+    let Ok(out_dir) = std::env::var("OUT_DIR").map(PathBuf::from) else {
+        panic!("Compiler should set OUT_DIR!");
+    };
+
+    std::fs::write(out_dir.join("version.rs"), generated.trim()).unwrap_or_else(|_| {
+        panic!("build.rs version.rs inside outdir ({out_dir:?}) failed to write!")
+    });
 }

macros/Cargo.lock

@@ -64,18 +64,15 @@ pub fn generate_button_handler_enum(args: TokenStream) -> TokenStream {
         panic!("File path not found!");
     };
 
-    let read = std::fs::read_to_string(&path);
-    if let Err(_) = read {
+    let Ok(read) = std::fs::read_to_string(&path) else {
         return quote! {
             #[doc(hidden)]
             pub enum HandlersDerive {}
         }
         .into();
-    }
-
-    let read = read.unwrap();
-    let input_file = syn::parse_file(&read).unwrap();
+    };
 
+    let input_file = syn::parse_file(&read).expect("SYN Cannot parse file");
     let mut output_ty: Option<proc_macro2::TokenStream> = None;
     let mut output_enum = Vec::new();
     let mut output_enum_impl = Vec::new();

macros/src/lib.rs

@@ -30,8 +30,8 @@ impl Parse for TranslationsHandler {
 pub fn load_translations_macro(args: TokenStream) -> TokenStream {
     let TranslationsHandler { path } = syn::parse_macro_input!(args as TranslationsHandler);
 
-    let read = std::fs::read(&path).unwrap();
-    let translations: Vec<TranslationRecord> = serde_json::from_slice(&read).unwrap();
+    let read = std::fs::read(&path).expect("Cannot read translations file!");
+    let translations: Vec<TranslationRecord> = serde_json::from_slice(&read).unwrap_or(Vec::new());
 
     let translations_count = translations.len();
     let declaration = quote! {