Skip to content

Commit 144be58

Browse files
authored
<fix&upd>(console,build): fix mergeAbi merge constructors issue, update java sdk and code-gen version. (#859)
1 parent ca6e7f4 commit 144be58

File tree

4 files changed

+32
-31
lines changed

4 files changed

+32
-31
lines changed

.ci/ci_check.sh

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -177,40 +177,26 @@ java -version
177177
#cp src/integration-test/resources/config-example.toml src/integration-test/resources/config.toml
178178
download_tassl
179179

180-
LOG_INFO "------ download_binary: v3.4.0---------"
181-
download_binary "v3.4.0"
182-
download_build_chain "v3.4.0"
180+
LOG_INFO "------ download_binary: v3.11.0---------"
181+
download_binary "v3.11.0"
182+
download_build_chain "v3.11.0"
183183
LOG_INFO "------ check_standard_node---------"
184184
check_standard_node false
185185
LOG_INFO "------ check_sm_node---------"
186186
check_sm_node true
187187
LOG_INFO "------ check_basic---------"
188188
check_basic
189189

190-
LOG_INFO "------ download_binary: v3.3.0---------"
191-
download_binary "v3.3.0"
192-
download_build_chain "v3.3.0"
190+
LOG_INFO "------ download_binary: v3.7.3---------"
191+
download_binary "v3.7.3"
192+
download_build_chain "v3.7.3"
193193
LOG_INFO "------ check_standard_node---------"
194194
check_standard_node
195195
rm -rf ./bin
196196

197-
LOG_INFO "------ download_binary: v3.2.0---------"
198-
download_binary "v3.2.0"
199-
download_build_chain "v3.2.0"
200-
LOG_INFO "------ check_standard_node---------"
201-
check_standard_node -s
202-
rm -rf ./bin
203-
204-
LOG_INFO "------ download_binary: v3.1.0---------"
205-
download_binary "v3.1.0"
206-
download_build_chain "v3.1.0"
207-
LOG_INFO "------ check_standard_node---------"
208-
check_standard_node -s
209-
rm -rf ./bin
210-
211-
LOG_INFO "------ download_binary: v3.0.0---------"
212-
download_binary "v3.0.0"
213-
download_build_chain "v3.0.0"
197+
LOG_INFO "------ download_binary: v3.2.6---------"
198+
download_binary "v3.2.6"
199+
download_build_chain "v3.2.6"
214200
LOG_INFO "------ check_standard_node---------"
215201
check_standard_node -s
216202
rm -rf ./bin

.github/workflows/workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
os: [ubuntu-20.04, ubuntu-22.04, windows-2019, macos-latest]
17+
os: [ubuntu-20.04, ubuntu-22.04, windows-2019, macos-12]
1818
steps:
1919
- uses: actions/checkout@v2
2020
with:

build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ dependencies {
4040
//implementation 'org.fisco-bcos:solcJ:0.4.25.1'
4141
//implementation 'org.fisco-bcos:solcJ:0.6.10.1'
4242
//implementation 'org.fisco-bcos:solcJ:0.5.2.1'
43-
implementation 'org.fisco-bcos:solcJ:1.0.0-SNAPSHOT'
43+
implementation 'org.fisco-bcos:solcJ:1.0.0'
4444

45-
implementation ('org.fisco-bcos.java-sdk:fisco-bcos-java-sdk:3.8.0-SNAPSHOT') {
45+
implementation ('org.fisco-bcos.java-sdk:fisco-bcos-java-sdk:3.8.0') {
4646
exclude group: "org.slf4j"
4747
}
4848

@@ -53,7 +53,7 @@ dependencies {
5353
implementation('org.jline:jline:3.21.0')
5454
implementation('io.bretty:console-table-builder:1.2')
5555
implementation('com.github.jsqlparser:jsqlparser:2.0')
56-
implementation('org.fisco-bcos.code-generator:bcos-code-generator:1.6.0-SNAPSHOT') {
56+
implementation('org.fisco-bcos.code-generator:bcos-code-generator:1.6.0') {
5757
exclude group: "org.fisco-bcos.java-sdk"
5858
exclude group: "org.slf4j"
5959
}

src/main/java/console/contract/utils/ContractCompiler.java

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public static AbiAndBin compileSolToBinAndAbi(
246246

247247
String bin = sm ? "" : meta.bin;
248248
String smBin = sm ? meta.bin : "";
249-
String abi = mergeAbi(result);
249+
String abi = mergeAbi(contractName, result);
250250
AbiAndBin abiAndBin = new AbiAndBin(abi, bin, smBin, meta.devdoc);
251251

252252
// evm static analysis
@@ -350,19 +350,34 @@ public static String mergeSource(String currentDir, String sourceFile, Set<Strin
350350
return sourceBuffer.toString();
351351
}
352352

353-
public static String mergeAbi(CompilationResult result) throws JsonProcessingException {
353+
public static String mergeAbi(String mainContract, CompilationResult result)
354+
throws JsonProcessingException {
354355

355356
List<String> contractNames = result.getContractKeys();
356357
if (contractNames.isEmpty()) {
357358
return null;
358359
}
359360
ObjectReader objectReader = ObjectMapperFactory.getObjectReader();
360361
ArrayNode mainNode = (ArrayNode) objectReader.createArrayNode();
362+
CompilationResult.ContractMetadata main = result.getContract(mainContract);
363+
mainNode.addAll((ArrayNode) objectReader.readTree(main.abi));
364+
361365
for (String contractName : contractNames) {
362366
String key = contractName.substring(contractName.lastIndexOf(':') + 1);
363-
JsonNode jsonNode = objectReader.readTree(result.getContract(key).abi);
367+
if (key.equals(mainContract)) {
368+
continue;
369+
}
370+
371+
CompilationResult.ContractMetadata contract = result.getContract(key);
372+
JsonNode jsonNode = objectReader.readTree(contract.abi);
364373
if (jsonNode.isArray() && !jsonNode.isEmpty()) {
365-
mainNode.addAll((ArrayNode) jsonNode);
374+
ArrayNode arrayNode = (ArrayNode) jsonNode;
375+
for (JsonNode node : arrayNode) {
376+
if (node.has("type") && node.get("type").asText().equals("constructor")) {
377+
} else {
378+
mainNode.add(node);
379+
}
380+
}
366381
}
367382
}
368383
return mainNode.toString();

0 commit comments

Comments
 (0)