-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffWeeklyKSv2KSv2
Description
Problem
Part of the HybridApp SignIn page improvements
I encountered a degraded performance when developing a new sign-in page in the hybridApp and saw a lot of soft exceptions in logcat. They turned out to be react-native-performance-related
Unhandled SoftException
com.facebook.react.bridge.ReactNoCrashSoftException: raiseSoftException(callWithExistingReactInstance(callFunctionOnModule("RCTDeviceEventEmitter", "emit"))): Execute: reactInstance is null. Dropping work.
Solution
After bumping react-native-performance the amount of exceptions decreased but I could still see them. I cheked the library code and found another unguarded RCTDeviceEventEmitter usage, so I created an oblador/react-native-performance#117 fixing it and added a patch here
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffWeeklyKSv2KSv2