Merge pull request #65 from ExpediaGroup/issue-36

mroark1m · web-flow · commit 65f143354a8e · 2019-07-17T15:55:19.000-05:00
Fixes #36
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [2.0.1] - TBD
+
+### Added
+- Fixed problem adding new remote_metastores. - see [#36](https://github.com/ExpediaGroup/apiary-federation/issues/36)
+
 ## [2.0.0] - 2019-07-09
 
 ### Added
diff --git a/endpoints.tf b/endpoints.tf
@@ -43,6 +43,7 @@ resource "aws_vpc_endpoint" "remote_metastores" {
 data "external" "endpoint_dnsnames" {
   count   = "${length(var.remote_metastores)}"
   program = ["bash", "${path.module}/scripts/endpoint_dns_name.sh", "${aws_vpc_endpoint.remote_metastores.*.id[count.index]}", "${var.aws_region}"]
+  depends_on = ["aws_vpc_endpoint.remote_metastores"] #without explicit dependency, adding additional remote metastores fails, see https://github.com/ExpediaGroup/apiary-federation/issues/36. 
 }
 
 data "template_file" "remote_metastores_yaml" {

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ resource "aws_vpc_endpoint" "remote_metastores" {`
`43`	`43`	`data "external" "endpoint_dnsnames" {`
`44`	`44`	`count = "${length(var.remote_metastores)}"`
`45`	`45`	`program = ["bash", "${path.module}/scripts/endpoint_dns_name.sh", "${aws_vpc_endpoint.remote_metastores.*.id[count.index]}", "${var.aws_region}"]`
	`46`	`+ depends_on = ["aws_vpc_endpoint.remote_metastores"] #without explicit dependency, adding additional remote metastores fails, see https://github.com/ExpediaGroup/apiary-federation/issues/36.`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`data "template_file" "remote_metastores_yaml" {`