fixes #59 endpoint dns names when AWS_DEFAULT_REGION environment variable is not set. (#60)

Author: rpoluri

CHANGELOG.md

@@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.1.2] - TBD
+
+### Changed
+- Fixes remote metastore CNAMEs when AWS_DEFAULT_REGION environment variable is not set - see[#59](https://github.com/ExpediaGroup/apiary-federation/issues/59)
+
 ## [1.1.1] - 2019-04-09
 
 ### Added

endpoints.tf

@@ -42,7 +42,7 @@ resource "aws_vpc_endpoint" "remote_metastores" {
 
 data "external" "endpoint_dnsnames" {
   count   = "${length(var.remote_metastores)}"
-  program = ["bash", "${path.module}/scripts/endpoint_dns_name.sh", "${aws_vpc_endpoint.remote_metastores.*.id[count.index]}"]
+  program = ["bash", "${path.module}/scripts/endpoint_dns_name.sh", "${aws_vpc_endpoint.remote_metastores.*.id[count.index]}", "${var.aws_region}"]
 }
 
 data "template_file" "remote_metastores_yaml" {
@@ -72,10 +72,13 @@ data "template_file" "local_metastores_yaml" {
 }
 
 resource "aws_route53_zone" "remote_metastore" {
-  count  = "${ var.enable_remote_metastore_dns == "" ? 0 : 1 }"
-  name   = "${local.remote_metastore_zone_prefix}-${var.aws_region}.${var.domain_extension}"
-  vpc_id = "${var.vpc_id}"
-  tags   = "${var.tags}"
+  count = "${ var.enable_remote_metastore_dns == "" ? 0 : 1 }"
+  name  = "${local.remote_metastore_zone_prefix}-${var.aws_region}.${var.domain_extension}"
+  tags  = "${var.tags}"
+
+  vpc = {
+    vpc_id = "${var.vpc_id}"
+  }
 }
 
 resource "aws_route53_record" "metastore_alias" {

scripts/endpoint_dns_name.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-dns_name=`aws ec2 describe-vpc-endpoints --vpc-endpoint-ids $1|jq -r ".VpcEndpoints[].DnsEntries[0].DnsName"`
+dns_name=`aws --region $2 ec2 describe-vpc-endpoints --vpc-endpoint-ids $1|jq -r ".VpcEndpoints[].DnsEntries[0].DnsName"`
 if [ "$dns_name" = "null" ]; then
   echo "dns_name for VPC endpoint is null, one issue which may cause this is an older version of the AWS CLI on the machine you run Terraform from." 1>&2
   exit 1