-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
Describe the bug
Behavior of var.enable_gluesync
is broken.
- In ECS, setting
enable_gluesync
tofalse
will still trigger HMS docker image to use glue sync, but the IAM policy is not created, so it fails. - In K8S, the env var
ENABLE_GLUESYNC
is never passed to the HMS docker image, so enabling glue sync doesn't work.
Additional context
- The ECS issue is because when TF vars were change to
boolean
instead of strings, the value forfalse
gets passed toENABLE_GLUESYNC
asfalse
. But thestartup.sh
code in the docker image does aif [ !-z $ENABLE_GLUESYNC ]
check, which sees the valuefalse
as non-empty, so enables glue sync. For the correct way of fixing this, see howenable_metrics
is being set in https://github.com/ExpediaGroup/apiary-data-lake/blob/master/templates.tf#L24. - The K8S issue looks like an oversight of passing the correct value to
ENABLE_GLUESYNC
.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers