add fill!(CatArray, val)

Author: alyst

src/array.jl

@@ -338,6 +338,8 @@ Base.IndexStyle(::Type{<:CategoricalArray}) = IndexLinear()
     @inbounds A.refs[I...] = get!(A.pool, v)
 end
 
+Base.fill!(A::CategoricalArray, v::Any) = (fill!(A.refs, get!(A.pool, v)); A)
+
 function mergelevels(ordered, levels...)
     T = Base.promote_eltype(levels...)
     res = Array{T}(0)

src/missingarray.jl

@@ -22,5 +22,7 @@ end
     @inbounds A.refs[I...] = 0
 end
 
+Base.fill!(A::CategoricalArray{>:Missing}, ::Missing) = (fill!(A.refs, 0); A)
+
 in(x::Missing, y::CategoricalArray) = false
 in(x::Missing, y::CategoricalArray{>:Missing}) = !all(v -> v > 0, y.refs)

test/11_array.jl

@@ -136,6 +136,14 @@ using CategoricalArrays: DefaultRefType, catvaluetype, leveltype
     @test levels(x2) !== levels(x)
     @test isordered(x2) == isordered(x)
 
+    x2 = copy(x)
+    @test fill!(x2, "a") === x2
+    @test x2 == ["a", "a", "a"]
+    @test levels(x2) == ["a", "b"]
+    fill!(x2, "c")
+    @test x2 == ["c", "c", "c"]
+    @test levels(x2) == ["a", "b", "c"]
+
     x[1] = x[2]
     @test x[1] === x.pool.valindex[2]
     @test x[2] === x.pool.valindex[2]

test/12_missingarray.jl

@@ -146,6 +146,17 @@ const ≅ = isequal
                 @test levels(x2) !== levels(x)
                 @test isordered(x2) == isordered(x)
 
+                x2 = copy(x)
+                @test fill!(x2, "a") === x2
+                @test x2 == ["a", "a", "a"]
+                @test levels(x2) == ["a", "b"]
+                fill!(x2, "c")
+                @test x2 == ["c", "c", "c"]
+                @test levels(x2) == ["a", "b", "c"]
+                fill!(x2, missing)
+                @test all(ismissing, x2)
+                @test levels(x2) == ["a", "b", "c"]
+
                 x[1] = x[2]
                 @test x[1] === x.pool.valindex[2]
                 @test x[2] === x.pool.valindex[2]