Skip to content

Commit f2164f8

Browse files
committed
Revert "Do not export CategoricalPool (JuliaData#109)"
This reverts commit a035708. CategoricalPool is actually used by several dependencies already.
1 parent a035708 commit f2164f8

13 files changed

+5
-14
lines changed

src/CategoricalArrays.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
__precompile__()
22
module CategoricalArrays
3-
export CategoricalValue, CategoricalString
3+
export CategoricalPool, CategoricalValue, CategoricalString
44
export AbstractCategoricalArray, AbstractCategoricalVector, AbstractCategoricalMatrix,
55
CategoricalArray, CategoricalVector, CategoricalMatrix
66
export AbstractMissingCategoricalArray, AbstractMissingCategoricalVector,

test/01_typedef.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
module TestTypeDef
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: DefaultRefType, level, reftype, leveltype, catvalue,
5-
iscatvalue, CategoricalPool
4+
using CategoricalArrays: DefaultRefType, level, reftype, leveltype, catvalue, iscatvalue
65

76
@testset "CategoricalPool, a b c order" begin
87
pool = CategoricalPool(

test/02_buildorder.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module TestUpdateOrder
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: DefaultRefType, CategoricalPool
4+
using CategoricalArrays: DefaultRefType
55

66
@testset "buildorder!(b a c)" begin
77
pool = CategoricalPool(

test/03_buildfields.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module TestBuildFields
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: DefaultRefType, CategoricalPool
4+
using CategoricalArrays: DefaultRefType
55

66
@testset "buildindex(), buildinvindex(), buildorder() for b a c" begin
77
index = ["b", "a", "c"]

test/04_constructors.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module TestConstructors
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: DefaultRefType, catvalue, CategoricalPool
4+
using CategoricalArrays: DefaultRefType, catvalue
55

66
@testset "Type parameter constraints" begin
77
# cannot use categorical value as level type

test/05_convert.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module TestConvert
22
using Base.Test
33
using CategoricalArrays
44
using CategoricalArrays: DefaultRefType, level, reftype, leveltype, catvalue, iscatvalue
5-
using CategoricalArrays: CategoricalPool
65

76
@testset "convert() for CategoricalPool{Int, DefaultRefType} and values" begin
87
pool = CategoricalPool([1, 2, 3])

test/06_length.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module TestLength
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: CategoricalPool
54

65
@testset "length(pool)" begin
76
pool = CategoricalPool([1, 2, 3])

test/06_show.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module TestShow
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: CategoricalPool
54

65
@testset "show() for CategoricalPool{String} and its values" begin
76
pool = CategoricalPool(["c", "b", "a"])

test/07_levels.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module TestLevels
22
using Base.Test
33
using CategoricalArrays
44
using CategoricalArrays: DefaultRefType, levels!
5-
using CategoricalArrays: CategoricalPool
65

76
@testset "CategoricalPool{Int} updates levels/index/order correctly" begin
87
pool = CategoricalPool([2, 1, 3])

test/08_equality.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module TestEquality
22
using Base.Test
33
using CategoricalArrays
4-
using CategoricalArrays: CategoricalPool
54

65
@testset "== and isequal() for CategoricalPool{Int} and CategoricalPool{Float64}" begin
76
pool1 = CategoricalPool([1, 2, 3])

0 commit comments

Comments
 (0)