Merge pull request JuliaData#104 from alyst/add_fill

add fill!(CatArray, val)

Author: cjprybol

src/array.jl

@@ -338,6 +338,9 @@ Base.IndexStyle(::Type{<:CategoricalArray}) = IndexLinear()
     @inbounds A.refs[I...] = get!(A.pool, v)
 end
 
+Base.fill!(A::CategoricalArray, v::Any) =
+    (fill!(A.refs, get!(A.pool, convert(leveltype(A), v))); A)
+
 function mergelevels(ordered, levels...)
     T = Base.promote_eltype(levels...)
     res = Array{T}(0)

src/missingarray.jl

@@ -22,5 +22,7 @@ end
     @inbounds A.refs[I...] = 0
 end
 
+Base.fill!(A::CategoricalArray{>:Missing}, ::Missing) = (fill!(A.refs, 0); A)
+
 in(x::Missing, y::CategoricalArray) = false
 in(x::Missing, y::CategoricalArray{>:Missing}) = !all(v -> v > 0, y.refs)

test/13_arraycommon.jl

@@ -427,6 +427,37 @@ end
         @test !isordered(x)
     end
 
+    @testset "fill!()" begin
+        x = CategoricalArray{Union{String, T}}(["a", "b", "c"])
+        x2 = copy(x)
+        @test fill!(x2, "a") === x2
+        @test x2 == ["a", "a", "a"]
+        @test levels(x2) == ["a", "b", "c"]
+
+        @test fill!(x2, x[2]) == ["b", "b", "b"]
+        @test levels(x2) == ["a", "b", "c"]
+
+        x2 = copy(x)
+        @test_throws MethodError fill!(x2, 3)
+        @test x2 == x
+
+        if T === Missing
+            x2 = fill!(copy(x), missing)
+            @test all(ismissing, x2)
+        else
+            @test_throws MethodError fill!(x2, missing)
+            @test x2 == x
+        end
+
+        fill!(x2, :c)
+        @test x2 == ["c", "c", "c"]
+        @test levels(x2) == ["a", "b", "c"]
+
+        fill!(x2, "0")
+        @test x2 == ["0", "0", "0"]
+        @test levels(x2) == ["a", "b", "c", "0"]
+    end
+
     @testset "overflow of reftype is detected and doesn't corrupt data and levels" begin
         res = @test_throws LevelsException{Int, UInt8} CategoricalArray{Union{T, Int}, 1, UInt8}(256:-1:1)
         @test res.value.levels == [1]