From 92c149fa2f8213283cc41c61fc938c67ce71dfcd Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Thu, 24 Apr 2025 17:35:11 -0700 Subject: [PATCH] clang-tidy: avoid warning with stringFormat found with performance-inefficient-string-concatenation Signed-off-by: Rosen Penev --- src/sonymn_int.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sonymn_int.cpp b/src/sonymn_int.cpp index 175496efcc..5a015c10f7 100644 --- a/src/sonymn_int.cpp +++ b/src/sonymn_int.cpp @@ -1316,9 +1316,9 @@ static void findLensSpecFlags(const Value& value, std::string& flagsStart, std:: if (auto temp = i.mask & joinedV0V7) { // Check if a flag matches in the current LensSpecFlags if (auto f = Exiv2::find(i.flags, temp)) { if (i.prepend) - flagsStart = (flagsStart.empty() ? f->label_ : f->label_ + std::string(" ") + flagsStart); + flagsStart = flagsStart.empty() ? f->label_ : stringFormat("{} {}", f->label_, flagsStart); else - flagsEnd = (flagsEnd.empty() ? f->label_ : flagsEnd + std::string(" ") + f->label_); + flagsEnd = flagsEnd.empty() ? f->label_ : stringFormat("{} {}", flagsEnd, f->label_); continue; } // Should never get in here. LensSpecFlags.mask should contain all the