-
Notifications
You must be signed in to change notification settings - Fork 92
Description
My mods and Everest install are up to date
Yes
I have recreated the bug with only Everest OR a minimum number of mods enabled
Yes
Describe the bug
If the installation of Everest fails after coreification but before the apphost setup, the next install will cause Olympus to delete the orig
directory under the assumption that this is a vanilla install and safe to backup.
This causes the vanilla executable in orig/Celeste.exe
to be coreified. Trying to run coreified vanilla will always crash with this message in the Event Viewer on Windows:
Application: Celeste.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: exception code e0434352, exception address 00007FF9899C7F7A
Stack:
Steps to reproduce
- Try to install Everest
- Have the install fail after coreification but before the apphost setup (so before or while running MonoMod)
- Install Everest from Olympus
orig/Celeste.exe
is coreified
Expected behavior
orig/Celeste.exe
remains a .NET Framework assembly and runs normally.
Operating System
N/A (OS-agnostic)
Everest Version
5800, but likely applies to all core (4465+) versions
Mods required to reproduce
No response
Additional context
Since MiniInstaller
does not do any cleanup if installation fails, Celeste.exe
is converted to .NET Core without applying any of the Everest patches. Then, when installing from Olympus, it finds that Celeste.exe
is vanilla (unaware of the fact that it's coreified), and deletes orig
under the oblivious assumption that this is a vanilla install and safe to back up.
The deletion logic can be found in Olympus' CmdInstallEverest.