Used persisted UI connection state when saving. Fixes #450. (#452)

EranBoudjnah · web-flow · commit 8b5100048f93 · 2025-07-02T12:11:17.000Z
* Increased emulator version to 35.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -92,7 +92,7 @@ jobs:
       - name: Run connected tests
         uses: ReactiveCircus/android-emulator-runner@v2
         with:
-          api-level: 28
+          api-level: 35
           target: google_apis
           arch: x86_64
           profile: Nexus 6
diff --git a/.github/workflows/script/run_tests.sh b/.github/workflows/script/run_tests.sh
@@ -1,7 +1,10 @@
 #!/bin/bash
 
 set +e
-./gradlew connectedCheck --no-daemon
+./gradlew assembleDebug assembleDebugAndroidTest --no-daemon
+adb install app/build/outputs/apk/espresso/app-espresso.apk
+adb install app/build/outputs/apk/androidTest/espresso/app-espresso-androidTest.apk
+adb shell am instrument -w -m -e debug false \\n -e class 'com.mitteloupe.whoami.suite.SmokeTests' \\ncom.mitteloupe.whoami.test/com.mitteloupe.whoami.di.HiltTestRunner
 GRADLE_EXIT_CODE=$?
 set -e
 
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/launcher/FromScreen.kt b/app/src/androidTest/java/com/mitteloupe/whoami/launcher/FromScreen.kt
@@ -14,12 +14,10 @@ fun <ACTIVITY : AppCompatActivity> fromScreen(
 ) = AppLauncher {
     fromComposable(composeContentTestRule) { activity ->
         WhoAmITheme {
-            with(testAppDependenciesEntryPoint(activity).appNavHostDependencies) {
-                AppNavHost(
-                    supportFragmentManager = activity.supportFragmentManager,
-                    startDestination = startDestination
-                )
-            }
+            testAppDependenciesEntryPoint(activity).appNavHostDependencies.AppNavHost(
+                supportFragmentManager = activity.supportFragmentManager,
+                startDestination = startDestination
+            )
         }
     }.launch()
 }
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/screen/HistoryScreen.kt b/app/src/androidTest/java/com/mitteloupe/whoami/screen/HistoryScreen.kt
@@ -2,6 +2,7 @@ package com.mitteloupe.whoami.screen
 
 import androidx.recyclerview.widget.RecyclerView
 import androidx.recyclerview.widget.RecyclerView.ViewHolder
+import androidx.test.espresso.Espresso
 import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.assertion.ViewAssertions.matches
 import androidx.test.espresso.contrib.RecyclerViewActions.actionOnItemAtPosition
@@ -72,14 +73,23 @@ class HistoryScreen {
         )
     }
 
-    fun tapDeleteForRecord(position: Int) {
+    fun seeRecord(position: Int, ipAddress: String, city: String, postCode: String) {
+        seeIpRecord(ipAddress = ipAddress, position = position)
+        seeLocation(city = city, postCode = postCode, position = position)
+    }
+
+    fun tapDeleteButtonForRecord(position: Int) {
         onView(recordsList)
             .perform(scrollToPosition<ViewHolder>(position.zeroBased))
             .perform(
                 actionOnItemAtPosition<ViewHolder>(position.zeroBased, clickChildView(deleteButton))
             )
     }
 
+    fun tapBackButton() {
+        Espresso.pressBack()
+    }
+
     private val Int.zeroBased
         get() = this - 1
 }
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/screen/HomeScreen.kt b/app/src/androidTest/java/com/mitteloupe/whoami/screen/HomeScreen.kt
@@ -20,6 +20,7 @@ class HomeScreen {
     private val postCodeLabel = hasText("CM14")
     private val timeZoneLabel = hasText("Europe/London")
     private val internetServiceProviderLabel = hasText("TalkTalk Limited")
+    private val saveDetailsButton = hasText("Save Details")
     private val openSourceNoticesButton = hasText("Open Source Notices")
 
     fun ComposeContentTestRule.seeIpAddressLabel() {
@@ -58,7 +59,11 @@ class HomeScreen {
         assertIsDisplayed(internetServiceProviderLabel)
     }
 
-    fun ComposeContentTestRule.tapOpenSourceNotices() {
+    fun ComposeContentTestRule.tapSaveDetailsButton() {
+        onNode(saveDetailsButton).performTouchInput { click() }
+    }
+
+    fun ComposeContentTestRule.tapOpenSourceNoticesButton() {
         onNode(openSourceNoticesButton).performTouchInput { click() }
     }
 
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/suite/SmokeTests.kt b/app/src/androidTest/java/com/mitteloupe/whoami/suite/SmokeTests.kt
@@ -0,0 +1,18 @@
+package com.mitteloupe.whoami.suite
+
+import androidx.compose.ui.test.ExperimentalTestApi
+import com.mitteloupe.whoami.test.HistoryHighlightedIpAddressTest
+import com.mitteloupe.whoami.test.HistoryTest
+import com.mitteloupe.whoami.test.HomeTest
+import org.junit.runner.RunWith
+import org.junit.runners.Suite
+import org.junit.runners.Suite.SuiteClasses
+
+@OptIn(ExperimentalTestApi::class)
+@RunWith(Suite::class)
+@SuiteClasses(
+    HistoryTest::class,
+    HistoryHighlightedIpAddressTest::class,
+    HomeTest::class
+)
+class SmokeTests
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/test/HistoryHighlightedIpAddressTest.kt b/app/src/androidTest/java/com/mitteloupe/whoami/test/HistoryHighlightedIpAddressTest.kt
@@ -52,14 +52,4 @@ class HistoryHighlightedIpAddressTest : BaseTest() {
             seeNonHighlightedRecord(ipAddress = ipAddress2, position = 2)
         }
     }
-
-    private fun HistoryScreen.seeRecord(
-        position: Int,
-        ipAddress: String,
-        city: String,
-        postCode: String
-    ) {
-        seeIpRecord(ipAddress = ipAddress, position = position)
-        seeLocation(city = city, postCode = postCode, position = position)
-    }
 }
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/test/HistoryTest.kt b/app/src/androidTest/java/com/mitteloupe/whoami/test/HistoryTest.kt
@@ -63,7 +63,7 @@ class HistoryTest : BaseTest() {
                 )
             }
             seeRecord(position = 2, ipAddress = "1.1.1.1", city = "Aberdeen", postCode = "AA11 2BB")
-            tapDeleteForRecord(position = 1)
+            tapDeleteButtonForRecord(position = 1)
             retry(repeat = 20) {
                 seeRecord(
                     position = 1,
@@ -92,14 +92,4 @@ class HistoryTest : BaseTest() {
             }
         }
     }
-
-    private fun HistoryScreen.seeRecord(
-        position: Int,
-        ipAddress: String,
-        city: String,
-        postCode: String
-    ) {
-        seeIpRecord(ipAddress = ipAddress, position = position)
-        seeLocation(city = city, postCode = postCode, position = position)
-    }
 }
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/test/HomeSaveRecordTest.kt b/app/src/androidTest/java/com/mitteloupe/whoami/test/HomeSaveRecordTest.kt
@@ -0,0 +1,76 @@
+package com.mitteloupe.whoami.test
+
+import androidx.compose.ui.test.ExperimentalTestApi
+import androidx.compose.ui.test.junit4.createAndroidComposeRule
+import com.mitteloupe.whoami.di.TestActivity
+import com.mitteloupe.whoami.launcher.fromScreen
+import com.mitteloupe.whoami.localstore.KEY_VALUE_NO_HISTORY
+import com.mitteloupe.whoami.screen.HistoryScreen
+import com.mitteloupe.whoami.screen.HomeScreen
+import com.mitteloupe.whoami.server.REQUEST_RESPONSE_GET_IP
+import com.mitteloupe.whoami.server.REQUEST_RESPONSE_GET_IP_DETAILS
+import com.mitteloupe.whoami.test.annotation.LocalStore
+import com.mitteloupe.whoami.test.annotation.ServerRequestResponse
+import com.mitteloupe.whoami.test.launcher.AppLauncher
+import com.mitteloupe.whoami.test.test.BaseTest
+import com.mitteloupe.whoami.test.test.retry
+import com.mitteloupe.whoami.ui.main.route.Home
+import dagger.hilt.android.testing.HiltAndroidTest
+import javax.inject.Inject
+import org.junit.Test
+
+@HiltAndroidTest
+@ExperimentalTestApi
+class HomeSaveRecordTest : BaseTest() {
+    override val composeTestRule = createAndroidComposeRule<TestActivity>()
+
+    override val startActivityLauncher: AppLauncher by lazy {
+        fromScreen(composeTestRule, Home)
+    }
+
+    @Inject
+    lateinit var homeScreen: HomeScreen
+
+    @Inject
+    lateinit var historyScreen: HistoryScreen
+
+    @Test
+    @ServerRequestResponse([REQUEST_RESPONSE_GET_IP, REQUEST_RESPONSE_GET_IP_DETAILS])
+    @LocalStore(localStoreDataIds = [KEY_VALUE_NO_HISTORY])
+    fun givenConnectedWhenNavigatingAwayAndBackThenSavesRecord() {
+        with(composeTestRule) {
+            with(homeScreen) {
+                seeCityLabel()
+                tapSaveDetailsButton()
+            }
+
+            with(historyScreen) {
+                retry(repeat = 20) {
+                    seeRecord(
+                        position = 1,
+                        ipAddress = "1.2.3.4",
+                        city = "Brentwood",
+                        postCode = "CM14"
+                    )
+                }
+                tapBackButton()
+            }
+
+            with(homeScreen) {
+                seeCityLabel()
+                tapSaveDetailsButton()
+            }
+
+            with(historyScreen) {
+                retry(repeat = 20) {
+                    seeRecord(
+                        position = 1,
+                        ipAddress = "1.2.3.4",
+                        city = "Brentwood",
+                        postCode = "CM14"
+                    )
+                }
+            }
+        }
+    }
+}
diff --git a/app/src/androidTest/java/com/mitteloupe/whoami/test/HomeTest.kt b/app/src/androidTest/java/com/mitteloupe/whoami/test/HomeTest.kt
@@ -65,7 +65,7 @@ class HomeTest : BaseTest() {
         Intents.init()
         with(composeTestRule) {
             with(homeScreen) {
-                tapOpenSourceNotices()
+                tapOpenSourceNoticesButton()
             }
 
             with(openSourceNoticesScreen) {
diff --git a/app/src/main/java/com/mitteloupe/whoami/di/HomeUiModule.kt b/app/src/main/java/com/mitteloupe/whoami/di/HomeUiModule.kt
@@ -7,6 +7,7 @@ import com.mitteloupe.whoami.architecture.ui.navigation.mapper.NavigationEventDe
 import com.mitteloupe.whoami.home.presentation.navigation.HomePresentationNavigationEvent
 import com.mitteloupe.whoami.home.presentation.viewmodel.HomeViewModel
 import com.mitteloupe.whoami.home.ui.di.HomeDependencies
+import com.mitteloupe.whoami.home.ui.mapper.ConnectionDetailsPresentationMapper
 import com.mitteloupe.whoami.home.ui.mapper.ConnectionDetailsUiMapper
 import com.mitteloupe.whoami.home.ui.mapper.ErrorUiMapper
 import com.mitteloupe.whoami.home.ui.mapper.HomeNotificationUiMapper
@@ -39,13 +40,17 @@ object HomeUiModule {
     @Provides
     fun providesErrorUiMapper(resources: Resources) = ErrorUiMapper(resources)
 
+    @Provides
+    fun providesConnectionDetailsPresentationMapper() = ConnectionDetailsPresentationMapper()
+
     @Provides
     fun providesConnectionDetailsUiMapper() = ConnectionDetailsUiMapper()
 
     @Provides
     fun providesHomeDependencies(
         homeViewModel: HomeViewModel,
         homeViewStateUiMapper: HomeViewStateUiMapper,
+        connectionDetailsPresentationMapper: ConnectionDetailsPresentationMapper,
         connectionDetailsUiMapper: ConnectionDetailsUiMapper,
         homeNavigationMapper: @JvmSuppressWildcards
         NavigationEventDestinationMapper<HomePresentationNavigationEvent>,
@@ -55,6 +60,7 @@ object HomeUiModule {
     ) = HomeDependencies(
         homeViewModel,
         homeViewStateUiMapper,
+        connectionDetailsPresentationMapper,
         connectionDetailsUiMapper,
         homeNavigationMapper,
         homeNotificationMapper,
diff --git a/app/src/main/java/com/mitteloupe/whoami/ui/main/AppNavHost.kt b/app/src/main/java/com/mitteloupe/whoami/ui/main/AppNavHost.kt
@@ -1,7 +1,10 @@
 package com.mitteloupe.whoami.ui.main
 
 import android.view.View
+import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.fillMaxSize
+import androidx.compose.foundation.layout.statusBars
+import androidx.compose.foundation.layout.windowInsetsPadding
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableIntStateOf
@@ -39,7 +42,9 @@ fun AppNavHostDependencies.AppNavHost(
             val history: History = backStackEntry.toRoute()
             FragmentContainer(
                 containerId = containerId,
-                modifier = Modifier.fillMaxSize(),
+                modifier = Modifier
+                    .fillMaxSize()
+                    .windowInsetsPadding(WindowInsets.statusBars),
                 fragmentManager = supportFragmentManager,
                 commit = { containerId ->
                     replace(containerId, HistoryFragment.newInstance(history.highlightedIpAddress))
diff --git a/app/src/main/java/com/mitteloupe/whoami/ui/main/FragmentContainer.kt b/app/src/main/java/com/mitteloupe/whoami/ui/main/FragmentContainer.kt
@@ -10,7 +10,7 @@ import androidx.compose.ui.viewinterop.AndroidView
 import androidx.fragment.app.FragmentContainerView
 import androidx.fragment.app.FragmentManager
 import androidx.fragment.app.FragmentTransaction
-import androidx.fragment.app.commit
+import androidx.fragment.app.commitNow
 
 @Composable
 fun FragmentContainer(
@@ -33,7 +33,7 @@ fun FragmentContainer(
                 fragmentManager.onContainerAvailable(view)
                 onFragmentViewCreated(view.id)
             } else {
-                fragmentManager.commit { commit(view.id) }
+                fragmentManager.commitNow { commit(view.id) }
                 initialized = true
             }
         }
diff --git a/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/di/HomeDependencies.kt b/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/di/HomeDependencies.kt
@@ -8,13 +8,15 @@ import com.mitteloupe.whoami.home.presentation.model.HomePresentationNotificatio
 import com.mitteloupe.whoami.home.presentation.model.HomeViewState
 import com.mitteloupe.whoami.home.presentation.navigation.HomePresentationNavigationEvent
 import com.mitteloupe.whoami.home.presentation.viewmodel.HomeViewModel
+import com.mitteloupe.whoami.home.ui.mapper.ConnectionDetailsPresentationMapper
 import com.mitteloupe.whoami.home.ui.mapper.ConnectionDetailsUiMapper
 import com.mitteloupe.whoami.home.ui.mapper.ErrorUiMapper
 import com.mitteloupe.whoami.home.ui.mapper.HomeViewStateUiMapper
 
 data class HomeDependencies(
     val homeViewModel: HomeViewModel,
     val homeViewStateUiMapper: HomeViewStateUiMapper,
+    val connectionDetailsPresentationMapper: ConnectionDetailsPresentationMapper,
     val connectionDetailsUiMapper: ConnectionDetailsUiMapper,
     private val homeNavigationMapper:
     NavigationEventDestinationMapper<HomePresentationNavigationEvent>,
diff --git a/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsPresentationMapper.kt b/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsPresentationMapper.kt
@@ -0,0 +1,26 @@
+package com.mitteloupe.whoami.home.ui.mapper
+
+import com.mitteloupe.whoami.home.presentation.model.HomeViewState
+import com.mitteloupe.whoami.home.ui.model.ConnectionDetailsUiModel
+import java.util.*
+
+private val locales by lazy {
+    Locale.getISOCountries().map { country -> Locale("en", country) }
+}
+
+class ConnectionDetailsPresentationMapper {
+    fun toPresentation(connectionDetails: ConnectionDetailsUiModel) = HomeViewState.Connected(
+        ipAddress = connectionDetails.ipAddress,
+        city = connectionDetails.cityIconLabel?.label,
+        region = connectionDetails.regionIconLabel?.label,
+        geolocation = connectionDetails.geolocationIconLabel?.label?.replace(", ", ","),
+        postCode = connectionDetails.postCode?.label,
+        timeZone = connectionDetails.timeZone?.label,
+        internetServiceProviderName = connectionDetails.internetServiceProviderName?.label,
+        countryCode = connectionDetails.countryIconLabel?.label?.let { countryName ->
+            locales.firstOrNull { locale ->
+                locale.displayCountry == countryName
+            }
+        }?.country
+    )
+}
diff --git a/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/view/HomeScreen.kt b/home/ui/src/main/java/com/mitteloupe/whoami/home/ui/view/HomeScreen.kt
@@ -35,11 +35,10 @@ import com.mitteloupe.whoami.home.ui.view.widget.LoadingAnimationContainer
 
 @Composable
 fun HomeDependencies.Home(navController: NavController, modifier: Modifier = Modifier) {
-    fun relaySavingToViewModel(connectionDetails: HomeViewState) {
-        require(connectionDetails is HomeViewState.Connected) {
-            "Unexpected click, not connected."
-        }
-        homeViewModel.onSaveDetailsAction(connectionDetails)
+    fun relaySavingToViewModel(connectionDetails: ConnectionDetailsUiModel) {
+        val presentationConnection = connectionDetailsPresentationMapper
+            .toPresentation(connectionDetails)
+        homeViewModel.onSaveDetailsAction(presentationConnection)
     }
 
     ScreenEnterObserver {
@@ -68,7 +67,11 @@ fun HomeDependencies.Home(navController: NavController, modifier: Modifier = Mod
         connectionDetails = connectionDetails,
         errorMessage = errorMessage,
         analytics = analytics,
-        onSaveDetailsClick = { relaySavingToViewModel(viewState) },
+        onSaveDetailsClick = {
+            val latestConnectionDetails = connectionDetails
+            requireNotNull(latestConnectionDetails)
+            relaySavingToViewModel(latestConnectionDetails)
+        },
         onViewHistoryClick = { homeViewModel.onViewHistoryAction() },
         onOpenSourceNoticesClick = { homeViewModel.onOpenSourceNoticesAction() },
         modifier = modifier
diff --git a/home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsPresentationMapperTest.kt b/home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsPresentationMapperTest.kt
diff --git a/home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsUiMapperTest.kt b/home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsUiMapperTest.kt

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package com.mitteloupe.whoami.screen`
`2`	`2`
`3`	`3`	`import androidx.recyclerview.widget.RecyclerView`
`4`	`4`	`import androidx.recyclerview.widget.RecyclerView.ViewHolder`
	`5`	`+import androidx.test.espresso.Espresso`
`5`	`6`	`import androidx.test.espresso.Espresso.onView`
`6`	`7`	`import androidx.test.espresso.assertion.ViewAssertions.matches`
`7`	`8`	`import androidx.test.espresso.contrib.RecyclerViewActions.actionOnItemAtPosition`
`@@ -72,14 +73,23 @@ class HistoryScreen {`
`72`	`73`	`)`
`73`	`74`	`}`
`74`	`75`
`75`		`- fun tapDeleteForRecord(position: Int) {`
	`76`	`+ fun seeRecord(position: Int, ipAddress: String, city: String, postCode: String) {`
	`77`	`+ seeIpRecord(ipAddress = ipAddress, position = position)`
	`78`	`+ seeLocation(city = city, postCode = postCode, position = position)`
	`79`	`+ }`
	`80`	`+`
	`81`	`+ fun tapDeleteButtonForRecord(position: Int) {`
`76`	`82`	`onView(recordsList)`
`77`	`83`	`.perform(scrollToPosition<ViewHolder>(position.zeroBased))`
`78`	`84`	`.perform(`
`79`	`85`	`actionOnItemAtPosition<ViewHolder>(position.zeroBased, clickChildView(deleteButton))`
`80`	`86`	`)`
`81`	`87`	`}`
`82`	`88`
	`89`	`+ fun tapBackButton() {`
	`90`	`+ Espresso.pressBack()`
	`91`	`+ }`
	`92`	`+`
`83`	`93`	`private val Int.zeroBased`
`84`	`94`	`get() = this - 1`
`85`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,14 +52,4 @@ class HistoryHighlightedIpAddressTest : BaseTest() {`
`52`	`52`	`seeNonHighlightedRecord(ipAddress = ipAddress2, position = 2)`
`53`	`53`	`}`
`54`	`54`	`}`
`55`		`-`
`56`		`- private fun HistoryScreen.seeRecord(`
`57`		`- position: Int,`
`58`		`- ipAddress: String,`
`59`		`- city: String,`
`60`		`- postCode: String`
`61`		`- ) {`
`62`		`- seeIpRecord(ipAddress = ipAddress, position = position)`
`63`		`- seeLocation(city = city, postCode = postCode, position = position)`
`64`		`- }`
`65`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class HistoryTest : BaseTest() {`
`63`	`63`	`)`
`64`	`64`	`}`
`65`	`65`	`seeRecord(position = 2, ipAddress = "1.1.1.1", city = "Aberdeen", postCode = "AA11 2BB")`
`66`		`- tapDeleteForRecord(position = 1)`
	`66`	`+ tapDeleteButtonForRecord(position = 1)`
`67`	`67`	`retry(repeat = 20) {`
`68`	`68`	`seeRecord(`
`69`	`69`	`position = 1,`
`@@ -92,14 +92,4 @@ class HistoryTest : BaseTest() {`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`	`}`
`95`		`-`
`96`		`- private fun HistoryScreen.seeRecord(`
`97`		`- position: Int,`
`98`		`- ipAddress: String,`
`99`		`- city: String,`
`100`		`- postCode: String`
`101`		`- ) {`
`102`		`- seeIpRecord(ipAddress = ipAddress, position = position)`
`103`		`- seeLocation(city = city, postCode = postCode, position = position)`
`104`		`- }`
`105`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ class HomeTest : BaseTest() {`
`65`	`65`	`Intents.init()`
`66`	`66`	`with(composeTestRule) {`
`67`	`67`	`with(homeScreen) {`
`68`		`- tapOpenSourceNotices()`
	`68`	`+ tapOpenSourceNoticesButton()`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`with(openSourceNoticesScreen) {`