Skip to content

Commit b30898f

Browse files
author
Kevin Martin
committed
doucment changes
1 parent 155f6c5 commit b30898f

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,17 @@ assignees: ''
1010
**Version of the script**
1111
Look in the stored procedure, and it'll have a version date & number near the top. Put that in here. If it's not the current version (dated in the last month), then upgrade to the current version and test that before reporting a bug - we fix a lot of stuff in each new build. We'll flat out close bug reports for older builds.
1212

13+
14+
**What is the Check Id?**
15+
16+
1317
**What is the current behavior?**
1418

19+
1520
**If the current behavior is a bug, please provide the steps to reproduce.**
1621

22+
1723
**What is the expected behavior?**
1824

25+
1926
**Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?**

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,14 @@ assignees: ''
1010
**Is your feature request related to a problem? Please describe.**
1111
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
1212

13+
1314
**Describe the solution you'd like**
1415
A clear and concise description of what you want to happen.
1516

17+
1618
**Describe alternatives you've considered**
1719
A clear and concise description of any alternative solutions or features you've considered.
1820

21+
1922
**Are you ready to build the code for the feature?**
2023
As much as we'd love to build everything that everyone wants for free, we need your help. Open source is built with your help and code. Are you ready to commit time to this project? Have you got existing code you can help contribute to solve the problem?

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ Although the MONEY data type generally takes less storage and takes less bandwid
390390

391391
You can't require everyone to stop using national characters or accents any more. Names are likely to have accents in them if spelled properly, and international addresses and language strings will almost certainly have accents and national characters that can’t be represented by 8-bit ASCII!
392392

393-
**Future columns to check:**
393+
**Column names to check:**
394394
- FirstName
395395
- MiddleName
396396
- LastName
@@ -651,7 +651,7 @@ It is common to need a database to operate under different names.
651651
## Using @@IDENTITY Instead of SCOPE_IDENTITY
652652
**Check Id:** [NONE YET]
653653

654-
The generation of an IDENTITY value is not transactional, so in some circumstances, @@IDENTITY returns the wrong value and not the value from the row you just inserted. This is especially true when using triggers that insert data, depending on when the triggers fire. The SCOPE_IDENTITY function is safer because it always relates to the current batch (within the same scope). Also consider using the IDENT_CURRENT function, which returns the last IDENTITY value regardless of session or scope. The OUTPUT clause is a better and safer way of capturing identity values.
654+
The generation of an identity value is not transactional, so in some circumstances, ```@@IDENTITY``` returns the wrong value and not the value from the row you just inserted. This is especially true when using triggers that insert data, depending on when the triggers fire. The ```SCOPE_IDENTITY``` function is safer because it always relates to the current batch (within the same scope). Also consider using the ```IDENT_CURRENT``` function, which returns the last identity value regardless of session or scope. The OUTPUT clause is a better and safer way of capturing identity values.
655655

656656

657657
## Using BETWEEN for DATETIME Ranges

0 commit comments

Comments
 (0)