Skip to content

Check for all dust is too strict #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JssDWt opened this issue Dec 10, 2022 · 0 comments
Open

Check for all dust is too strict #5805

JssDWt opened this issue Dec 10, 2022 · 0 comments

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Dec 10, 2022

Issue and Steps to Reproduce

  • Spin up two core lightning nodes, Alice and Bob
  • Alice allows dust reserve, Bob does not
  • Alice funds a zero reserve zero conf channel with Bob
  • Bob will now have a reserve of 0, but Alice will have a reserve of 1% of the channel capacity.
  • There is no way the commitment transaction will ever have zero outputs, because Alice is the funder and her side of the channel will have a reserve above the dust limit.

Currently, this gives the following error:
channel funding 100000sat too small for chosen parameters: a total of 573 HTLCs with dust value 546sat would result in a commitment_transaction without outputs. Please increase the funding amount or reduce the max_accepted_htlcs to ensure at least one non-dust output.

I'd expect this flow to give no error, as long as Alice's reserve is above the dust limit.

Relevant code: https://github.com/ElementsProject/lightning/blob/master/openingd/openingd.c#L481-L520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant