Group-direct-messages are broken

[BenWiederhake]

Steps to reproduce:

• Use Rocketchat 3.18.1
• Create a "direct message group" with multiple people (call them A, B, and C)
• Use it in the web client (i.e. send and receive messages to that group; regular text messages are enough to trigger it)

Expected behavior: A new tab opens in pidgin, and both sent and received messages appear in there and only in there.

Actual behavior: A new tab opens in pidgin, and the sent messages appear in there and only in there. However, the received messages appear as direct messages only from the sending person. So, additionally to the group tab, I also see new tabs with DMs from the people A, B, and C.

[EionRobb]

I've never been in a DM group before, I generally only use the regular group chats, so the code probably assumes that everything is either a public group, or a DM.

Are you able to get a debug log of some messages coming through, or is there a test server I can join to send some test messages to?

[BenWiederhake]

Technically I do have the log messages, but there are NDAs at play, so sending any logs means I have to carefully comb through the logs and err on the side of over-censoring, I don't think they would be useful afterwards. I also don't have a test server readily available, but I could try setting one up (assuming RocketChat really is Free Software as they claim).

[Thaodan]

Technically I do have the log messages, but there are NDAs at play, so sending any logs means I have to carefully comb through the logs and err on the side of over-censoring, I don't think they would be useful afterwards. I also don't have a test server readily available, but I could try setting one up (assuming RocketChat really is Free Software as they claim).

You can use the public rocket server open.rocket.chat. to test.