Fix new transaction notifications #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/fix-tx-notification
branch
from
a9e4880 to
fec2384
Compare
samholmes
approved these changes
Feb 4, 2025
|
/rebase |
github-actions
bot
force-pushed
the
william/fix-tx-notification
branch
from
8b4a406 to
333fda9
Compare
We had a cacth-22 situation, where we needed a valid checkpoint to consider any transaction new, but we wouldn't update the checkpoint until we saw a new transaction. Besides the catch-22, a fully-syncd wallet generally wouldn't have any activity that could update the checkpoint, leaving it stuck at undefined until a new transaction comes in, in which case that new transaction would never get a notification. Therefore, we need to set up an initial checkpoint at boot if we don't have one. This will be a one-time operation on a single device. After that, new devices will recieve the synced checkpoint, and incoming transactions will receive notifications.
swansontec
force-pushed
the
william/fix-tx-notification
branch
from
333fda9 to
88a84ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a cacth-22 situation, where we needed a valid checkpoint to consider any transaction new, but we wouldn't update the checkpoint until we saw a new transaction.
Besides the catch-22, a fully-syncd wallet generally wouldn't have any activity that could update the checkpoint, leaving it stuck at undefined until a new transaction comes in, in which case that new transaction would never get a notification. Therefore, we need to set up an initial checkpoint at boot if we don't have one. This will be a one-time operation on a single device. After that, new devices will recieve the synced checkpoint.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none