EPPlus does not recognise underline styling of a comment

[craigbrown]

EPPlus usage

Commercial use (I have a commercial license)

Environment

Windows

Epplus version

8.1.1

Spreadsheet application

Excel

Description

Hi! I reported #454 a while ago and it was very quickly fixed. However, there seems to have been a regression, as the unit test I wrote for that issue now fails - the comment1.Font.UnderLine line now incorrectly returns false.

Also when the file is saved with EPPlus, I can see the underlining on the comment is removed when I view it in Excel.

You can see this with the file and unit test in the #454 issue, but I have copied them below. Thanks.

[TestMethod]
public void TestCopyComment()
{
    using (var pck = OpenTemplatePackage("TestStyledComment.xlsx"))
    {
        // Get the comment object from the worksheet
        var wks = pck.Workbook.Worksheets["Sheet1"];
        var comment1 = wks.Comments[0];
        
        // Check that the comment in B2 has a custom style
        Assert.AreEqual("B2", comment1.Address);
        Assert.AreEqual("dcf0ff", comment1.BackgroundColor.Name);
        Assert.AreEqual(true, comment1.AutoFit);
        Assert.AreEqual("Tahoma", comment1.Font.FontName);
        Assert.AreEqual(9, comment1.Font.Size);
        Assert.AreEqual(true, comment1.Font.Bold);
        Assert.AreEqual(true, comment1.Font.Italic);
        Assert.AreEqual(true, comment1.Font.UnderLine);
        Assert.AreEqual("0", comment1.Font.Color.Name);
        
        // Copy the comment from B2 to A2 (also checking that this works when copying a range)
        wks.Cells["B1:B3"].Copy(wks.Cells["A1:A3"]);
        
        // Check the comment is copied with all properties intact
        var comment2 = wks.Comments[1];
        Assert.AreEqual("A2", comment2.Address);
        Assert.AreEqual(comment1.BackgroundColor.Name, comment2.BackgroundColor.Name);
        Assert.AreEqual(comment1.AutoFit, comment2.AutoFit);
        Assert.AreEqual(comment1.Font.FontName, comment2.Font.FontName);
        Assert.AreEqual(comment1.Font.Size, comment2.Font.Size);
        Assert.AreEqual(comment1.Font.Bold, comment2.Font.Bold);
        Assert.AreEqual(comment1.Font.Italic, comment2.Font.Italic);
        Assert.AreEqual(comment1.Font.UnderLine, comment2.Font.UnderLine);
        Assert.AreEqual(comment1.Font.Color.Name, comment2.Font.Color.Name);
    }
}

TestStyledComment.xlsx

(It looks like this regression was introduced in v7.1.0, specifically in commit af0e644 if that helps.)

[karlkallman]

Hello. Thank you for reporting this. We've looked into the issue and commited a fix. Hopefully this resolves your issue.

[craigbrown]

Thanks for the quick response! That does seem to fix the issue.