Windows installer has wrong line endings

[mastrogippo]

Bug Report Details

Testing on TPLINK M7350

/etc/init.d/rayhunter_daemon in windows installer Version 0.5.0 has windows line endings. When run it gives an error:

/ # /etc/init.d/rayhunter_daemon start
/bin/sh: /etc/init.d/rayhunter_daemon: not found

it's solved by fixing the line endings:

/ # sed -i 's/\r$//' /etc/init.d/rayhunter_daemon
/ # /etc/init.d/rayhunter_daemon start
Starting rayhunter: done

[untitaker]

I believe we are running into actions/checkout#135 where GitHub's Windows CI "helpfully" converts line endings when building the release artifact.

[mastrogippo]

@untitaker I see that the file in the release zip has the correct line endings, so I guess it's a problem during the transfer?
Also, I had to rename the installer to installer.exe to make PS recognize it as an executable.

[untitaker]

so i didn't test the patch yet, but our windows zips are actually assembled on linux like all other zipfiles. only the installer binary itself is built on windows.

[gaykitty]

I can confirm that the embedded text files in the Windows installer have \r\n line endings whereas the Linux ones do not.

[mastrogippo]

that's odd, I see the correct line endings on the 0.5 windows release :

[untitaker]

that's odd, I see the correct line endings on the 0.5 windows release

I think you downloaded the zip file and extracted it. the zipfile does contain the correct line endings, it's when you check out the rayhunter git repo on windows that git will "fix" the lineendings. that's what we do in the windows build job for the installer binary.

there's a fix now at #493