Optimize the tag of ViewBinding

Author: DylanCaiCoding

viewbinding-base/src/main/java/com/dylanc/viewbinding/base/ViewBindingUtil.kt

@@ -34,11 +34,7 @@ object ViewBindingUtil {
   fun <VB : ViewBinding> inflateWithGeneric(genericOwner: Any, layoutInflater: LayoutInflater): VB =
     withGenericBindingClass<VB>(genericOwner) { clazz ->
       clazz.getMethod("inflate", LayoutInflater::class.java).invoke(null, layoutInflater) as VB
-    }.also { binding ->
-      if (genericOwner is ComponentActivity && binding is ViewDataBinding) {
-        binding.lifecycleOwner = genericOwner
-      }
-    }
+    }.withLifecycleOwner(genericOwner)
 
   @JvmStatic
   fun <VB : ViewBinding> inflateWithGeneric(genericOwner: Any, parent: ViewGroup): VB =
@@ -49,21 +45,31 @@ object ViewBindingUtil {
     withGenericBindingClass<VB>(genericOwner) { clazz ->
       clazz.getMethod("inflate", LayoutInflater::class.java, ViewGroup::class.java, Boolean::class.java)
         .invoke(null, layoutInflater, parent, attachToParent) as VB
-    }.also { binding ->
-      if (genericOwner is Fragment && binding is ViewDataBinding) {
-        binding.lifecycleOwner = genericOwner.viewLifecycleOwner
-      }
-    }
+    }.withLifecycleOwner(genericOwner)
 
   @JvmStatic
+  @Suppress("DEPRECATION")
+  fun <VB : ViewBinding> getBindingWithGeneric(genericOwner: Any, view: View): VB =
+    view.getTag(R.id.tag_view_binding) as? VB ?: bindWithGeneric<VB>(genericOwner, view)
+      .also { view.setTag(R.id.tag_view_binding, it) }
+
+  @JvmStatic
+  @Deprecated(
+    "Use ViewBindingUtil.getBindingWithGeneric<VB>(genericOwner, view) instead.",
+    ReplaceWith("ViewBindingUtil.getBindingWithGeneric<VB>(genericOwner, view)")
+  )
   fun <VB : ViewBinding> bindWithGeneric(genericOwner: Any, view: View): VB =
     withGenericBindingClass<VB>(genericOwner) { clazz ->
       clazz.getMethod("bind", View::class.java).invoke(null, view) as VB
-    }.also { binding ->
-      if (genericOwner is Fragment && binding is ViewDataBinding) {
-        binding.lifecycleOwner = genericOwner.viewLifecycleOwner
-      }
+    }.withLifecycleOwner(genericOwner)
+
+  private fun <VB : ViewBinding> VB.withLifecycleOwner(genericOwner: Any) = apply {
+    if (this is ViewDataBinding && genericOwner is ComponentActivity) {
+      lifecycleOwner = genericOwner
+    } else if (this is ViewDataBinding && genericOwner is Fragment) {
+      lifecycleOwner = genericOwner.viewLifecycleOwner
     }
+  }
 
   private fun <VB : ViewBinding> withGenericBindingClass(genericOwner: Any, block: (Class<VB>) -> VB): VB {
     var genericSuperclass = genericOwner.javaClass.genericSuperclass

viewbinding-base/src/main/res/values/ids.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <item name="tag_view_binding" type="id" />
+</resources>

viewbinding-brvah/src/main/java/com/dylanc/viewbinding/brvah/BaseViewHolderUtil.kt

@@ -1,3 +1,19 @@
+/*
+ * Copyright (c) 2020. Dylan Cai
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 @file:Suppress("unused")
 
 package com.dylanc.viewbinding.brvah
@@ -8,4 +24,4 @@ import com.chad.library.adapter.base.viewholder.BaseViewHolder
 
 @Suppress("UNCHECKED_CAST")
 fun <VB : ViewBinding> BaseViewHolder.getBinding(bind: (View) -> VB): VB =
-  itemView.getTag(Int.MIN_VALUE) as? VB ?: bind(itemView).also { itemView.setTag(Int.MIN_VALUE, it) }
+  itemView.getTag(R.id.tag_view_binding) as? VB ?: bind(itemView).also { itemView.setTag(R.id.tag_view_binding, it) }

viewbinding-brvah/src/main/res/values/ids.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <item name="tag_view_binding" type="id" />
+</resources>

viewbinding-ktx/src/main/java/com/dylanc/viewbinding/View.kt

@@ -23,6 +23,6 @@ inline fun <reified VB : ViewBinding> View.getBinding() = getBinding(VB::class.j
 
 @Suppress("UNCHECKED_CAST")
 fun <VB : ViewBinding> View.getBinding(clazz: Class<VB>) =
-  getTag(Int.MIN_VALUE) as? VB ?: (clazz.getMethod("bind", View::class.java)
+  getTag(R.id.tag_view_binding) as? VB ?: (clazz.getMethod("bind", View::class.java)
     .invoke(null, this) as VB)
-    .also { setTag(Int.MIN_VALUE, it) }
+    .also { setTag(R.id.tag_view_binding, it) }

viewbinding-ktx/src/main/res/values/ids.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <item name="tag_view_binding" type="id" />
+</resources>

viewbinding-nonreflection-ktx/src/main/java/com/dylanc/viewbinding/nonreflection/View.kt

@@ -25,5 +25,5 @@ import androidx.viewbinding.ViewBinding
 
 @Suppress("UNCHECKED_CAST")
 fun <VB : ViewBinding> View.getBinding(bind: (View) -> VB): VB =
-  getTag(Int.MIN_VALUE) as? VB ?: bind(this).also { setTag(Int.MIN_VALUE, it) }
+  getTag(R.id.tag_view_binding) as? VB ?: bind(this).also { setTag(R.id.tag_view_binding, it) }
 

viewbinding-nonreflection-ktx/src/main/res/values/ids.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <item name="tag_view_binding" type="id" />
+</resources>