Skip to content

Commit ac85fe3

Browse files
Optimize sample code
1 parent ed6dea3 commit ac85fe3

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

app/src/main/java/com/dylanc/viewbinding/sample/MainActivity.kt

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,7 @@ class MainActivity : AppCompatActivity() {
3333
private val binding by binding(ActivityMainBinding::inflate)
3434
private val loadingDialog by lazy { LoadingDialogFragment() }
3535
private val handler = Handler(Looper.getMainLooper())
36-
private val listAdapter = ListAdapter<Foo, ItemFooBinding>(DiffCallback()) {
37-
with(binding) {
38-
tvFoo.text = it.value
39-
}
40-
}
41-
private val list = listOf(
42-
Foo("item 1"),
43-
Foo("item 2"),
44-
Foo("item 3")
45-
)
36+
private val list = listOf(Foo("item 1"), Foo("item 2"), Foo("item 3"))
4637

4738
override fun onCreate(savedInstanceState: Bundle?) {
4839
super.onCreate(savedInstanceState)
@@ -53,11 +44,15 @@ class MainActivity : AppCompatActivity() {
5344
loadingDialog.dismiss()
5445
}, 2000)
5546
}
56-
recyclerView.adapter = listAdapter
57-
listAdapter.submitList(list)
47+
recyclerView.adapter = adapter
48+
adapter.submitList(list)
5849
}
5950
}
6051

52+
private val adapter = ListAdapter<Foo, ItemFooBinding>(DiffCallback()) {
53+
binding.tvFoo.text = it.value
54+
}
55+
6156
class DiffCallback : DiffUtil.ItemCallback<Foo>() {
6257
override fun areItemsTheSame(oldItem: Foo, newItem: Foo) = oldItem.value == newItem.value
6358
override fun areContentsTheSame(oldItem: Foo, newItem: Foo) = oldItem.value == newItem.value

0 commit comments

Comments
 (0)