add: lints for errors.rs

Rejyr · Rejyr · commit e3bb2ebfbfba · 2023-01-09T17:07:25.000-05:00
diff --git a/compiler/rustc_lint/src/errors.rs b/compiler/rustc_lint/src/errors.rs
@@ -1,3 +1,5 @@
+#![deny(rustc::untranslatable_diagnostic)]
+#![deny(rustc::diagnostic_outside_of_impl)]
 use rustc_errors::{
     fluent, AddToDiagnostic, Diagnostic, ErrorGuaranteed, Handler, IntoDiagnostic,
     SubdiagnosticMessage,
@@ -38,7 +40,7 @@ impl AddToDiagnostic for OverruledAttributeSub {
             OverruledAttributeSub::NodeSource { span, reason } => {
                 diag.span_label(span, fluent::lint_node_source);
                 if let Some(rationale) = reason {
-                    #[allow(rustc::diagnostic_outside_of_impl)]
+                    #[allow(rustc::untranslatable_diagnostic)]
                     diag.note(rationale.as_str());
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#![deny(rustc::untranslatable_diagnostic)]`
	`2`	`+#![deny(rustc::diagnostic_outside_of_impl)]`
`1`	`3`	`use rustc_errors::{`
`2`	`4`	`fluent, AddToDiagnostic, Diagnostic, ErrorGuaranteed, Handler, IntoDiagnostic,`
`3`	`5`	`SubdiagnosticMessage,`
`@@ -38,7 +40,7 @@ impl AddToDiagnostic for OverruledAttributeSub {`
`38`	`40`	`OverruledAttributeSub::NodeSource { span, reason } => {`
`39`	`41`	`diag.span_label(span, fluent::lint_node_source);`
`40`	`42`	`if let Some(rationale) = reason {`
`41`		`- #[allow(rustc::diagnostic_outside_of_impl)]`
	`43`	`+ #[allow(rustc::untranslatable_diagnostic)]`
`42`	`44`	`diag.note(rationale.as_str());`
`43`	`45`	`}`
`44`	`46`	`}`