Skip to content

Commit 3d7baee

Browse files
committed
fix cross-platform test bugs
More portable way to make python 2/3 portable. Strip Args line (with hardcoded paths) from debug counters output.
1 parent 3685689 commit 3d7baee

File tree

38 files changed

+11
-39
lines changed

38 files changed

+11
-39
lines changed

src/test/run-make-fulldeps/coverage-reports-base/Makefile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,13 @@ endif
6161
--instr-profile="$(TMPDIR)"/$@.profdata \
6262
$(call BIN,"$(TMPDIR)"/$@) \
6363
> "$(TMPDIR)"/actual_show_coverage.$@.txt \
64-
2> "$(TMPDIR)"/actual_show_coverage_counters.$@.txt
64+
2> "$(TMPDIR)"/show_coverage_stderr.$@.txt
65+
66+
# The first line (beginning with "Args:" contains hard-coded, build-specific
67+
# file paths. Strip that line and keep the remaining lines with counter debug
68+
# data.
69+
tail -n +2 "$(TMPDIR)"/show_coverage_stderr.$@.txt \
70+
> "$(TMPDIR)"/actual_show_coverage_counters.$@.txt
6571

6672
ifdef RUSTC_BLESS_TEST
6773
cp "$(TMPDIR)"/actual_show_coverage.$@.txt \

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.closure.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/closure.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/closure
21
Counter in file 0 20:21 -> 20:38, #1
32
Counter in file 0 21:20 -> 21:28, (#1 + 0)
43
Counter in file 0 21:29 -> 23:18, #2

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.drop_trait.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/drop_trait.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/drop_trait
21
Counter in file 0 9:24 -> 11:6, #1
32
Counter in file 0 15:9 -> 17:42, #1
43
Counter in file 0 19:8 -> 19:12, (#1 + 0)

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.generics.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/generics.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/generics
21
Counter in file 0 17:24 -> 19:6, #1
32
Counter in file 0 17:24 -> 19:6, #1
43
Counter in file 0 23:9 -> 28:28, #1

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.if.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/if.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/if
21
Counter in file 0 8:5 -> 18:10, #1
32
Counter in file 0 21:9 -> 21:16, (#1 + 0)
43
Counter in file 0 22:5 -> 27:6, #2

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.if_else.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/if_else.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/if_else
21
Counter in file 0 7:9 -> 11:16, #1
32
Counter in file 0 12:5 -> 17:6, #2
43
Counter in file 0 20:9 -> 22:16, (#1 - #2)

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.inner_items.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/inner_items.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/inner_items
21
Counter in file 0 19:13 -> 19:18, #1
32
Counter in file 0 20:13 -> 20:14, #2
43
Counter in file 0 20:17 -> 20:22, (#1 + 0)

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.lazy_boolean.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/lazy_boolean.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/lazy_boolean
21
Counter in file 0 7:9 -> 9:42, #1
32
Counter in file 0 10:8 -> 10:15, (#1 + 0)
43
Counter in file 0 10:16 -> 14:6, #2

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.loop_break_value.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/loop_break_value.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/loop_break_value
21
Counter in file 0 3:11 -> 13:2, #1
32
Emitting segments for file: ../coverage/loop_break_value.rs
43
Combined regions:

src/test/run-make-fulldeps/coverage-reports-base/expected_show_coverage_counters.loops_and_branches.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
Args: /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-cov show --debug --Xdemangler=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-demangler --show-line-counts-or-regions --instr-profile=/usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/loops_and_branches.profdata /usr/local/google/home/richkadel/rust/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/coverage-reports-base/coverage-reports-base/loops_and_branches
21
Counter in file 0 10:12 -> 10:16, #1
32
Counter in file 0 11:16 -> 11:21, #2
43
Counter in file 0 14:14 -> 14:15, (#2 - #5)

0 commit comments

Comments
 (0)