Flags for namespaces to watch and max concurrent reconciles.

Author: Tyrion85

README.md

@@ -9,6 +9,16 @@ Work in progress.
 Name "kubedb" clashes with an open-source project: https://github.com/kubedb
 We're going to have naming "clashes" (not technical, but on human level) if we ever decide to use that one.
 
+TODO: Write proper README file.
+
+Config options:
+
+Argument | Default value | Example | Purpose |
+---------|---------------|---------|---------|
+--metrics-addr | :8080 | :8080 | Metrics port |
+--enable-leader-election | false | true | Enable leader election |
+--namespaces | "" | devops,default |  Namespaces to watch. Default: watch all namespaces |
+--max-concurrent-reconciles | 1 | 5 | Maximum concurrent reconciles. This config covers all controllers. TODO maybe have a separate flag for each controller? |
 
 
 

controllers/mongodbdatabase_controller.go

@@ -27,6 +27,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/controller"
 )
 
 // MongoDBDatabaseReconciler reconciles a MongoDBDatabase object
@@ -133,10 +134,12 @@ func (r *MongoDBDatabaseReconciler) Reconcile(req ctrl.Request) (ctrl.Result, er
 	return r.updateAndReturn(&ctx, &database, &log)
 }
 
-func (r *MongoDBDatabaseReconciler) SetupWithManager(mgr ctrl.Manager) error {
+func (r *MongoDBDatabaseReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurrentReconciles int) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&infrav1beta1.MongoDBDatabase{}).
-		Complete(r)
+		WithOptions(controller.Options{
+			MaxConcurrentReconciles: maxConcurrentReconciles,
+		}).Complete(r)
 }
 
 func (r *MongoDBDatabaseReconciler) updateAndReturn(ctx *context.Context, database *infrav1beta1.MongoDBDatabase, log *logr.Logger) (ctrl.Result, error) {

controllers/postgresqldatabase_controller.go

@@ -27,6 +27,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/controller"
 )
 
 // PostgreSQLDatabaseReconciler reconciles a PostgreSQLDatabase object
@@ -144,10 +145,12 @@ func (r *PostgreSQLDatabaseReconciler) Reconcile(req ctrl.Request) (ctrl.Result,
 	return r.updateAndReturn(&ctx, &database, &log)
 }
 
-func (r *PostgreSQLDatabaseReconciler) SetupWithManager(mgr ctrl.Manager) error {
+func (r *PostgreSQLDatabaseReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurrentReconciles int) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&infrav1beta1.PostgreSQLDatabase{}).
-		Complete(r)
+		WithOptions(controller.Options{
+			MaxConcurrentReconciles: maxConcurrentReconciles,
+		}).Complete(r)
 }
 
 func (r *PostgreSQLDatabaseReconciler) updateAndReturn(ctx *context.Context, database *infrav1beta1.PostgreSQLDatabase, log *logr.Logger) (ctrl.Result, error) {

main.go

@@ -21,7 +21,9 @@ import (
 	mongodbAPI "github.com/doodlescheduling/kubedb/common/db/mongodb"
 	"github.com/doodlescheduling/kubedb/common/vault"
 	"os"
+	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/healthz"
+	"strings"
 
 	postgresqlAPI "github.com/doodlescheduling/kubedb/common/db/postgresql"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -50,21 +52,34 @@ func init() {
 func main() {
 	var metricsAddr string
 	var enableLeaderElection bool
+	var namespacesConfig string
+	var maxConcurrentReconciles int
 	flag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
 	flag.BoolVar(&enableLeaderElection, "enable-leader-election", false,
 		"Enable leader election for controller manager. "+
 			"Enabling this will ensure there is only one active controller manager.")
+	flag.StringVar(&namespacesConfig, "namespaces", "", "Comma-separated list of namespaces to watch. If not set, all namespaces will be watched.")
+	flag.IntVar(&maxConcurrentReconciles, "max-concurrent-reconciles", 1, "Maximum number of concurrent reconciles. Default is 1.")
 	flag.Parse()
 
 	ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
 
-	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
+	namespaces := strings.Split(namespacesConfig, ",")
+	options := ctrl.Options{
 		Scheme:             scheme,
 		MetricsBindAddress: metricsAddr,
 		Port:               9443,
 		LeaderElection:     enableLeaderElection,
 		LeaderElectionID:   "99a96989.doodle.com",
-	})
+	}
+	if len(namespaces) > 0 && namespaces[0] != "" {
+		options.NewCache = cache.MultiNamespacedCacheBuilder(namespaces)
+		setupLog.Info("watching configured namespaces", "namespaces", namespaces)
+	} else {
+		setupLog.Info("watching all namespaces")
+	}
+
+	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
 	if err != nil {
 		setupLog.Error(err, "unable to start manager")
 		os.Exit(1)
@@ -93,7 +108,7 @@ func main() {
 		Scheme:      mgr.GetScheme(),
 		ServerCache: mongoDBServerCache,
 		VaultCache:  vaultCache,
-	}).SetupWithManager(mgr); err != nil {
+	}).SetupWithManager(mgr, maxConcurrentReconciles); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "MongoDBDatabase")
 		os.Exit(1)
 	}
@@ -106,7 +121,7 @@ func main() {
 		Scheme:      mgr.GetScheme(),
 		ServerCache: postgreSQLServerCache,
 		VaultCache:  vaultCache,
-	}).SetupWithManager(mgr); err != nil {
+	}).SetupWithManager(mgr, maxConcurrentReconciles); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "PostgreSQLDatabase")
 		os.Exit(1)
 	}