Skip to content

Commit 81ca82e

Browse files
committed
added reference reconcile fix
1 parent 4b7b0d7 commit 81ca82e

8 files changed

+28
-87
lines changed

config/crd/bases/dbprovisioning.infra.doodle.com_mongodbdatabases.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.2.5
7+
controller-gen.kubebuilder.io/version: v0.3.0
88
creationTimestamp: null
99
name: mongodbdatabases.dbprovisioning.infra.doodle.com
1010
spec:

config/crd/bases/dbprovisioning.infra.doodle.com_mongodbusers.yaml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.2.5
7+
controller-gen.kubebuilder.io/version: v0.3.0
88
creationTimestamp: null
99
name: mongodbusers.dbprovisioning.infra.doodle.com
1010
spec:
@@ -75,6 +75,17 @@ spec:
7575
required:
7676
- name
7777
type: object
78+
roles:
79+
default:
80+
- name: readWrite
81+
items:
82+
properties:
83+
name:
84+
type: string
85+
required:
86+
- name
87+
type: object
88+
type: array
7889
required:
7990
- credentials
8091
- database

config/crd/bases/dbprovisioning.infra.doodle.com_postgresqldatabases.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.2.5
7+
controller-gen.kubebuilder.io/version: v0.3.0
88
creationTimestamp: null
99
name: postgresqldatabases.dbprovisioning.infra.doodle.com
1010
spec:

config/crd/bases/dbprovisioning.infra.doodle.com_postgresqlusers.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.2.5
7+
controller-gen.kubebuilder.io/version: v0.3.0
88
creationTimestamp: null
99
name: postgresqlusers.dbprovisioning.infra.doodle.com
1010
spec:

controllers/mongodbuser_controller.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (r *MongoDBUserReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurrent
5151
func(o client.Object) []string {
5252
usr := o.(*infrav1beta1.MongoDBUser)
5353
return []string{
54-
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Credentials),
54+
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Credentials.Name),
5555
}
5656
},
5757
); err != nil {
@@ -63,7 +63,7 @@ func (r *MongoDBUserReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurrent
6363
func(o client.Object) []string {
6464
usr := o.(*infrav1beta1.MongoDBUser)
6565
return []string{
66-
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Database),
66+
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Database.Name),
6767
}
6868
},
6969
); err != nil {
@@ -93,14 +93,14 @@ func (r *MongoDBUserReconciler) requestsForSecretChange(o client.Object) []recon
9393
ctx := context.Background()
9494
var list infrav1beta1.MongoDBUserList
9595
if err := r.List(ctx, &list, client.MatchingFields{
96-
secretIndexKey: objectKey(s).String(),
96+
credentialsIndexKey: objectKey(s).String(),
9797
}); err != nil {
9898
return nil
9999
}
100100

101101
var reqs []reconcile.Request
102102
for _, i := range list.Items {
103-
r.Log.Info("referenced secret from a mongodbuser change detected, reconcile binding", "namespace", i.GetNamespace(), "name", i.GetName())
103+
r.Log.Info("referenced secret from a mongodbuser change detected, reconcile", "namespace", i.GetNamespace(), "name", i.GetName())
104104
reqs = append(reqs, reconcile.Request{NamespacedName: objectKey(&i)})
105105
}
106106

@@ -123,7 +123,7 @@ func (r *MongoDBUserReconciler) requestsForDatabaseChange(o client.Object) []rec
123123

124124
var reqs []reconcile.Request
125125
for _, i := range list.Items {
126-
r.Log.Info("referenced database from a mongodbuser change detected, reconcile binding", "namespace", i.GetNamespace(), "name", i.GetName())
126+
r.Log.Info("referenced database from a mongodbuser change detected, reconcile", "namespace", i.GetNamespace(), "name", i.GetName())
127127
reqs = append(reqs, reconcile.Request{NamespacedName: objectKey(&i)})
128128
}
129129

controllers/postgresqluser_controller.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (r *PostgreSQLUserReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurr
5151
func(o client.Object) []string {
5252
usr := o.(*infrav1beta1.PostgreSQLUser)
5353
return []string{
54-
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Credentials),
54+
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Credentials.Name),
5555
}
5656
},
5757
); err != nil {
@@ -63,7 +63,7 @@ func (r *PostgreSQLUserReconciler) SetupWithManager(mgr ctrl.Manager, maxConcurr
6363
func(o client.Object) []string {
6464
usr := o.(*infrav1beta1.PostgreSQLUser)
6565
return []string{
66-
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Database),
66+
fmt.Sprintf("%s/%s", usr.GetNamespace(), usr.Spec.Database.Name),
6767
}
6868
},
6969
); err != nil {
@@ -93,14 +93,14 @@ func (r *PostgreSQLUserReconciler) requestsForSecretChange(o client.Object) []re
9393
ctx := context.Background()
9494
var list infrav1beta1.PostgreSQLUserList
9595
if err := r.List(ctx, &list, client.MatchingFields{
96-
secretIndexKey: objectKey(s).String(),
96+
credentialsIndexKey: objectKey(s).String(),
9797
}); err != nil {
9898
return nil
9999
}
100100

101101
var reqs []reconcile.Request
102102
for _, i := range list.Items {
103-
r.Log.Info("referenced secret from a postgresqluser change detected, reconcile binding", "namespace", i.GetNamespace(), "name", i.GetName())
103+
r.Log.Info("referenced secret from a postgresqluser change detected, reconcile", "namespace", i.GetNamespace(), "name", i.GetName())
104104
reqs = append(reqs, reconcile.Request{NamespacedName: objectKey(&i)})
105105
}
106106

@@ -123,7 +123,7 @@ func (r *PostgreSQLUserReconciler) requestsForDatabaseChange(o client.Object) []
123123

124124
var reqs []reconcile.Request
125125
for _, i := range list.Items {
126-
r.Log.Info("referenced database from a postgresqluser change detected, reconcile binding", "namespace", i.GetNamespace(), "name", i.GetName())
126+
r.Log.Info("referenced database from a postgresqluser change detected, reconcile", "namespace", i.GetNamespace(), "name", i.GetName())
127127
reqs = append(reqs, reconcile.Request{NamespacedName: objectKey(&i)})
128128
}
129129

go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@ require (
1313
github.com/spf13/viper v1.7.0
1414
github.com/xdg/stringprep v1.0.0 // indirect
1515
go.mongodb.org/mongo-driver v1.4.4
16+
golang.org/x/mod v0.4.0 // indirect
1617
golang.org/x/tools v0.1.0 // indirect
1718
k8s.io/api v0.20.2
1819
k8s.io/apiextensions-apiserver v0.20.2 // indirect
1920
k8s.io/apimachinery v0.20.2
2021
k8s.io/client-go v0.20.2
21-
mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed // indirect
22-
mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
23-
mvdan.cc/unparam v0.0.0-20210104141923-aac4ce9116a7 // indirect
2422
sigs.k8s.io/controller-runtime v0.8.0
2523
)

0 commit comments

Comments
 (0)