Skip to content

Commit 585b4dc

Browse files
committed
refactor: move browser names to a constant variable
1 parent f7851bc commit 585b4dc

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

lib/config/browser-name.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
export default {
2+
CHROME: 'CHROME',
3+
FIREFOX: 'FIREFOX',
4+
DESKTOP_SAFARI: 'DESKTOP_SAFARI',
5+
IE: 'IE',
6+
MOBILE_SAFARI: 'MOBILE_SAFARI',
7+
ETC: 'ETC',
8+
};

lib/config/max-canvas-size.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
import BROWSER_NAME from './browser-name';
2+
13
// see: https://github.com/jhildenbiddle/canvas-size#test-results
24
// see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/canvas#maximum_canvas_size
35
export default {
4-
chrome: 16384,
5-
firefox: 11180,
6-
'desktop safari': 16384,
7-
'internet explorer': 8192,
8-
'mobile safari': 4096,
9-
etc: 8192,
6+
[BROWSER_NAME.CHROME]: 16384,
7+
[BROWSER_NAME.FIREFOX]: 11180,
8+
[BROWSER_NAME.DESKTOP_SAFARI]: 16384,
9+
[BROWSER_NAME.IE]: 8192,
10+
[BROWSER_NAME.MOBILE_SAFARI]: 4096,
11+
[BROWSER_NAME.ETC]: 8192,
1012
};

lib/web-worker.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ import lib from './index';
44
import compress from './image-compression';
55
import { getNewCanvasAndCtx, isIOS } from './utils';
66
import UPNG from './UPNG';
7-
import MaxCanvasSize from './config/max-canvas-size';
7+
import MAX_CANVAS_SIZE from './config/max-canvas-size';
8+
import BROWSER_NAME from './config/browser-name';
89

910
let cnt = 0;
1011
let imageCompressionLibUrl;
@@ -89,7 +90,8 @@ function generateLib() {
8990
getNewCanvasAndCtx = ${getNewCanvasAndCtx}
9091
CustomFileReader = FileReader
9192
CustomFile = File
92-
MaxCanvasSize = ${JSON.stringify(MaxCanvasSize)}
93+
MAX_CANVAS_SIZE = ${JSON.stringify(MAX_CANVAS_SIZE)}
94+
BROWSER_NAME = ${JSON.stringify(BROWSER_NAME)}
9395
function compress (){return (${compress}).apply(null, arguments)}
9496
9597
// core-js

0 commit comments

Comments
 (0)