Does anyone need sub ensure_single_alleluia() to add alleluia to an empty string? #4575
Closed
Augustinus-Altovadensis
started this conversation in
Developers corner
Replies: 2 comments 2 replies
-
Should be safe to do so. @mbab Any concerns? |
Beta Was this translation helpful? Give feedback.
2 replies
-
Added in PR #4578 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Laudétur Jesus Christus!
as the title says, I have a simple question: does anyone need
sub ensure_single_alleluia()
fromLanguageTestTools.pm
to add alleluia to an empty string?Why am I asking: currently,
sub nocturn
fromspecmatins.pl
adds a versicle to the end of each Nocturn. If it has nothing to add, it adds nothing and the double\n\n
seems to get sorted out elsewhere. This is correct, as e.g. in Cistercian Ferial Matins, there is no versicle right after the second Nocturn's Antiphon, but after a Capitulum. However, during Paschaltide, functionensure_single_alleluia()
adds a single ", allelúia" to en empty string, which creates an artifact.It can be seen e.g. on "05-10-2025" in Matins.
The simplest solution seems to be to limit the
sub ensure_single_alleluia()
fromLanguageTestTools.pm
to a non-empty string, which is simple enough and also quite logical. But before submitting that, I want to ask, if it doesn't disturb someone other's code.Thanks for an answer, God bless!
Beta Was this translation helpful? Give feedback.
All reactions